Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change order of moderation pipeline to ensure external phases can run (Fixes #4630) #4631

Closed
wants to merge 1 commit into from
Closed

Change order of moderation pipeline to ensure external phases can run (Fixes #4630) #4631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions server/src/core/server/services/comments/pipeline/phases/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,17 @@ export const moderationPhases: IntermediateModerationPhase[] = [
spam,
detectLinks,

// Apply any pre-existing conditions to these comments.
// If user-specific moderation is enabled, it should run before
// external phases as those won't have the required information
// about the user to decide on their own.
statusPreModerateNewCommenter,
statusPreModerate,
statusPreModerateUser,

// Run any external moderation phase that missed other filters.
external,

// If premoderation is required globally, it should act as a
// fallback in case external phases did not respond with
// a status.
statusPreModerate,
];