[CORL-3171] fix tenor search fetch's on prod #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures that we set the protocol properly on `useFetchWithAuth` as the `rootURL` does not come through with a protocol in prod. this is quietly being done for relay via the `modifyQuery` util's that also include `parseURL` and `buildURL` for the underlying fetch utility that is performing relay requests.
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
tessalt
approved these changes
Jul 15, 2024
prevents users from hitting a rate limit when typing
…' into fix/CORL-3171-tenor-url-protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixing the problem with missing protocol on tenor search queries
Updates
useFetchWithAuthto use the framework url utilities to process url's.useFetchWithAuth(among other things) as therootURLdoes not come through with a protocol in prod.modifyQueryutil's that also includeparseURLandbuildURLfor the underlying fetch utility that is performing relay requests. It is also being similarly used to generate a redirect url in theCommentPane.Fixing the rate limit issues when searching
Load moreand don't get results due to rate limiting, but that's less likely to happenThese changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None
Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md?N/A
How do I test this PR?
dev1and test posting tenor gifs in a prod-like environmenthttp://...through in itsrootURLWere any tests migrated to React Testing Library?
No
How do we deploy this PR?
develop