[CORL-3172] optimized redis query for counts v2 endpoint #4660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only shows if Tenor is toggled in `Admin > Config`, otherwise it uses Giphy
…-origin
[CORL-3177]: update to grab the ORIGIN from the count.js script for
update package to 9.0.8
allows us to use the familiar g, pg, pg-13, r values everywhere and just map them from 1-4 for tenor when necessary.
add max width to tenor image
bump version
stack tenor gif results tightly in a cascade grid
…fore-premod [CORL-3174] Move external mod phases to run before pre-moderation
update package
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
nick-funk
changed the base branch from
develop
to
feat/CORL-3172-counts-endpoint
- avoid repeating string key interp everywhere
nick-funk
commented
Sep 10, 2024
| } | ||
| }) | ||
| const redisCounts = await redis.mget( | ||
| ...storyIDs.map((id) => computeCountKey(tenant.id, id)) |
There was a problem hiding this comment.
redis really likes it when you ask for everything all at once, its scheduler is great at grabbing n-many keys and returning it in a fast serialized payload!
allows us to see whether a count came from redis, or mongo
…imized-redis-query # Conflicts: # server/src/core/server/app/handlers/api/story/count.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None
Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md?N/A
How do I test this PR?
Were any tests migrated to React Testing Library?
No
How do we deploy this PR?