05core: add coreos-ignition-delete-config.service for upgrade boots
#1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
previously approved these changes
May 13, 2022
overlay.d/05core/usr/lib/systemd/system/coreos-ignition-delete-config.service
Show resolved
Hide resolved
dustymabe
reviewed
May 17, 2022
overlay.d/05core/usr/lib/systemd/system/ignition-delete-config.service.d/10-flag-file.conf
Show resolved
Hide resolved
|
Added requested comments. |
Ignition 2.14.0 adds ignition-delete-config.service, which deletes Ignition configs from VMware and VirtualBox on first boot. Add coreos-ignition-delete-config.service to do the same thing on existing machines on upgrade, using a stamp file in /var/lib to avoid multiple runs. Add a drop-in for ignition-delete-config.service that creates a stamp file in /run, and then chain from that stamp to the long-term stamp in /var/lib, ensuring that we don't delete configs twice on newly- provisioned machines. The upstream service can't create the stamp directly in /var/lib because it runs before /var is mounted. Prevent coreos-ignition-delete-config.service from running if ignition-delete-config.service is masked, ensuring that the mask operation documented upstream prevents the config from ever being deleted, as intended. We can remove this after the next barrier release in FCOS and barrier equivalent in RHCOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignition 2.14.0 adds
ignition-delete-config.service, which deletes Ignition configs from VMware and VirtualBox on first boot. Addcoreos-ignition-delete-config.serviceto do the same thing on existing machines on upgrade, using a stamp file in/var/libto avoid multiple runs.Add a drop-in for
ignition-delete-config.servicethat creates a stamp file in/run, and then chain from that stamp to the long-term stamp in/var/lib, ensuring that we don't delete configs twice on newly-provisioned machines. The upstream service can't create the stamp directly in/var/libbecause it runs before/varis mounted.Prevent
coreos-ignition-delete-config.servicefrom running ifignition-delete-config.serviceis masked, ensuring that the mask operation documented upstream prevents the config from ever being deleted, as intended.We can remove this after the next barrier release in FCOS and barrier equivalent in RHCOS.
The plan is to do a coreos-status post documenting
systemctl mask ignition-delete-config.servicebefore shipping this.