This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
[WIP] Reimplement Azure Scale Sets #2429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@justaugustus can you please rebase and resolve the conflict? thanks! |
1 similar comment
|
@justaugustus can you please rebase and resolve the conflict? thanks! |
|
@cpanato Thanks for following up on this! I'm going to take a look at updating the PR next week. |
|
Closing this as it's drifted from upstream and I'm thinking of implementing it slightly differently. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, Tectonic Installer does not support Azure Scale Sets as a result of a limitation in the Azure VMSS API. The VMSS API does not allow a consumer to access individual nodes in a Scale Sets, meaning integration points, like Kubernetes Cloud Provider and attaching disks to individual nodes (a la Persistent Disks) is not supported.
In an effort to provide the richest feature set to all Azure customers, we made the decision to remove the Scale Sets implementation from the Tectonic Installer.
Support for Azure Scale Sets has been recently called out as a requirement in several venues, and we will need to push on the upstream Kubernetes / Microsoft Azure community to drive this forward.
This PR is intended as a reference implementation of Tectonic Installer using Azure Scale Sets and is here for testing purposes and early review.
There are no guarantees as to its' functionality and should be considered buyer beware.
Upstream tracking PR:
Kubernetes related:
Tectonic related:
In the meantime, @alexsomesan / @s-urbaniak / @squat, would you mind taking a first pass?
cc: @robszumski / @metral / @sym3tri / @colemickens