fix: Navigation issues and naming issues for video/wsi #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wayfarer3130
commented
Jul 10, 2024
| @@ -175,5 +175,6 @@ | |||
| "not dead", | |||
| "not ie < 11", | |||
| "not op_mini all" | |||
| ] | |||
| ], | |||
| "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | |||
There was a problem hiding this comment.
Yarn now enforces updating this. Sigh.
wayfarer3130
commented
Jul 10, 2024
| @@ -224,7 +224,7 @@ class VideoViewport extends Viewport implements IVideoViewport { | |||
| public setDataIds(imageIds: string[], options?: ImageSetOptions) { | |||
| this.setVideo( | |||
| imageIds[0], | |||
| (options?.viewReference?.sliceIndex as number) || 1 | |||
| ((options?.viewReference?.sliceIndex as number) || 0) + 1 | |||
There was a problem hiding this comment.
Wrong frame value as it is a frame#, not an index.
sedghi
reviewed
Jul 10, 2024
| * class inheritance values and member functions/proxy instances, but runs | ||
| * the risk that the raw object can be modified through side affects. | ||
| */ | ||
| addRaw: (imageId: string, payload: { metadata: any; type: string }) => { |
sedghi
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There was a request to change the generic metadata provider as to how to stores metadata for object based metadata. Also, changed some navigation setup so that WSI and Video viewports navigate correctly.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment