feat: stack scroll out of bounds event #1465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
requested changes
Sep 18, 2024
| direction: delta, | ||
| }; | ||
| triggerEvent(this.element, Events.STACK_SCROLL_OUT_OF_BOUNDS, eventData); | ||
| } |
There was a problem hiding this comment.
I'm not sure if this makes sense, it is talking about a tool event inside the viewport, i think this should not happen here, but rather in the scroll() utilitiy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered
STACK_SCROLL_OUT_OF_BOUNDSevent in thescrollfunction of the stack viewport. UpdatedstackManipulationToolsexample to demonstrate the events trigger.https://github.com/OHIF/OHIF-Office-Hours/blob/main/notes/2024-08-08.md - followed the guides in the answer here.