improve validation metrics for discarded samples and exemplars

Signed-off-by: Ben Ye <benye@amazon.com>
cortexproject · Sep 18, 2024 · 8e77bff · 8e77bff
1 parent b4c37ce
commit 8e77bff
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/pkg/distributor/distributor.go b/pkg/distributor/distributor.go
@@ -874,7 +874,13 @@ func (d *Distributor) prepareSeriesKeys(ctx context.Context, req *cortexpb.Write
 				d.validateMetrics.DiscardedSamples.WithLabelValues(
 					validation.DroppedByRelabelConfiguration,
 					userID,
-				).Add(float64(len(ts.Samples)))
+				).Add(float64(len(ts.Samples) + len(ts.Histograms)))
+
+				// all labels are gone, exemplars will be discarded
+				d.validateMetrics.DiscardedExemplars.WithLabelValues(
+					validation.DroppedByUserConfigurationOverride,
+					userID,
+				).Add(float64(len(ts.Exemplars)))
 				continue
 			}
 			ts.Labels = cortexpb.FromLabelsToLabelAdapters(l)
@@ -892,11 +898,15 @@ func (d *Distributor) prepareSeriesKeys(ctx context.Context, req *cortexpb.Write
 		}
 
 		if len(ts.Labels) == 0 {
-			d.validateMetrics.DiscardedExemplars.WithLabelValues(
+			d.validateMetrics.DiscardedSamples.WithLabelValues(
 				validation.DroppedByUserConfigurationOverride,
 				userID,
-			).Add(float64(len(ts.Samples)))
+			).Add(float64(len(ts.Samples) + len(ts.Histograms)))
 
+			d.validateMetrics.DiscardedExemplars.WithLabelValues(
+				validation.DroppedByUserConfigurationOverride,
+				userID,
+			).Add(float64(len(ts.Exemplars)))
 			continue
 		}