add support for 'AdvertiseAddr' and 'AdvertisePort' in memberlist config #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinschoonover
force-pushed
the
master
branch
2 times, most recently
from
b486fa7
to
a1118e9
Compare
Signed-off-by: Kevin Schoonover <me@kschoon.me>
kevinschoonover
force-pushed
the
master
branch
from
d8f169f
to
cc136e1
Compare
|
closing in favor of grafana/dskit#37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds 'advertise_addr' and 'advertise_port' to memberlist configuration to support the service being NATed behind another ip.
Which issue(s) this PR fixes:
Fixes #4359
Checklist
- [ ] Tests updated- unsure how to add these. If you can point me in the right direction, happy to take this onCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]