Query Frontend: queries with negative offset should check whether it is cacheable or not #5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawarpranav83
force-pushed
the
master
branch
from
1babdc2
to
b52f25b
Compare
|
@pawarpranav83 Thanks. Same comment as thanos-io/thanos#7011 |
pawarpranav83
force-pushed
the
master
branch
2 times, most recently
from
e310a35
to
79bb956
Compare
yeya24
requested changes
Dec 28, 2023
Signed-off-by: pawarpranav83 <pawarpranav@gmail.com>
pawarpranav83
force-pushed
the
master
branch
from
79bb956
to
9f7b714
Compare
yeya24
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Checks whether offset is negative or not, and if negative, it does not cache the query result.
Which issue(s) this PR fixes:
Fixes #5678
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]