Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeql workflow #5743

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Conversation

Kramer0x0
Copy link
Contributor

What this PR does:

This pull request integrates CodeQL, an Open Source semantic code analysis tool, into the upstream repository's workflow. By incorporating CodeQL, it enhances the repository's security posture by automatically detecting vulnerabilities and coding errors during the development process. This addition will ensure continuous and automated code quality checks, significantly improving the overall security and maintainability of the codebase.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Kramer0x0 , just one small nit.

@@ -19,6 +19,7 @@ test-build-deploy.yml specifies a workflow that runs all Cortex continuous integ
| test | Runs units tests on Cassandra testing framework. | CI |
| integration-configs-db | Integration tests for database configurations. | CI |
| integration | Runs integration tests after upgrading golang, pulling necessary docker images and downloading necessary module dependencies. | CI |
| Security/CodeQL | CodeQL is a semantic code analysis engine used for automating security checks, enabling developers to write and run queries to identify vulnerabilities and improve code security | CI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we format it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally! Sorry about that :)

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: Ryan West <rwest2@apple.com>
Signed-off-by: Ryan West <rwest2@apple.com>
Signed-off-by: Ryan West <rwest2@apple.com>
Signed-off-by: Ryan West <rwest2@apple.com>
Signed-off-by: Ryan West <rwest2@apple.com>
@friedrichg friedrichg merged commit 5306261 into cortexproject:master Jan 24, 2024
16 checks passed
@friedrichg
Copy link
Member

Thanks!

@alanprot
Copy link
Member

alanprot commented Feb 2, 2024

@Kramer0x0
Copy link
Contributor Author

Thanks @alanprot - let me look into it:
#5761 - raised this issue for now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants