Skip to content

Commit

Permalink
fix starship reading from the helmFile if present
Browse files Browse the repository at this point in the history
  • Loading branch information
Anmol1696 committed May 22, 2024
1 parent df72301 commit 60aeb14
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions clients/js/packages/cli/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@ export const loadConfig = (argv: any): Config => {
if (context.helmFile) {
const dir = dirname(argv.config || process.cwd());
context.helmFile = resolve(resolvePath(dir), context.helmFile);
starship = loadYaml(context.helmFile) as StarshipConfig
}

starship = loadYaml(context.helmFile) as StarshipConfig

console.log("starship: ", starship);

return {context, starship};
Expand Down Expand Up @@ -104,8 +103,7 @@ Examples:
$ starship setup
$ starship deploy --helmFile ./config/helm.yaml --helmName my-release
$ starship start-ports --config ./config/settings.json
$ starship undeploy --config ./config/settings.json
$ starship teardown
$ starship stop --config ./config/settings.json
Additional Help:
$ starship help Display this help information.
Expand Down
2 changes: 1 addition & 1 deletion clients/js/packages/client/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { readAndParsePackageJson } from './package';

export interface StarshipContext {
helmName?: string;
helmFile: string;
helmFile?: string;
helmRepo?: string;
helmRepoUrl?: string;
helmChart?: string;
Expand Down

0 comments on commit 60aeb14

Please sign in to comment.