Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Neutron Version v.4.2.0 #5203

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

pr0n00gler
Copy link
Contributor

No description provided.

@reversesigh
Copy link
Collaborator

I believe this was a halt upgrade, and for cosmovisor the binary belongs in the v4.0.1 folder. Instead of creating a new version for v4.2.1, it should become the recommended for the v4.0.0 series.

@JeremyParish69 JeremyParish69 marked this pull request as draft August 30, 2024 19:41
@pr0n00gler pr0n00gler marked this pull request as ready for review September 11, 2024 11:25
neutron/chain.json Outdated Show resolved Hide resolved
neutron/chain.json Outdated Show resolved Hide resolved
@@ -248,20 +253,58 @@
"type": "go",
"version": "v8.2.1"
}
},
{
"name": "v4.2.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there should be a single version object for all v4.2 versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it should be applied only at specific height, how can i specify it in a single version object?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the block height number to use should be when v4.2.0 started. The versions of components (language, sdk, ibc, cosmwasm, etc.) and the binaries should reflect the latest well-running/recommended version. Since v4.2.0, v4.2.1, and v4.2.2 are all compatible versions, it should be inconsequential to use the earliest version or the earlier version of components.

@JeremyParish69
Copy link
Collaborator

@reversesigh It seems like the various v4.2 versions could be grouped together, but different versions of components are captured in the more precise version objects for v4.2.x. Should this be forced together into a single object since all v4.2.x versions are all compatible (I believe)?

@reversesigh
Copy link
Collaborator

@reversesigh It seems like the various v4.2 versions could be grouped together, but different versions of components are captured in the more precise version objects for v4.2.x. Should this be forced together into a single object since all v4.2.x versions are all compatible (I believe)?

Correct. v4.2.1 should not be its own version, and should be the recommended binary for v4.2.x. v4.2.1 is in the upgrade folder for v4.2.0 in cosmovisor.

@JeremyParish69 JeremyParish69 changed the title Update Neutron in chain.json Update Neutron Version v.4.2.0 Sep 17, 2024
@JeremyParish69 JeremyParish69 marked this pull request as draft September 17, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants