ORM v1.0 Readiness Checklist #11088
Comments
This was referenced Mar 15, 2022
mergify bot
pushed a commit
that referenced
this issue
Mar 17, 2022
## Description Ref: #11088. First PR of several to add gRPC error codes and make sure that errors are a well-defined part of the API. Also introduces Cucumber-style BDD acceptance tests into the SDK via https://github.com/regen-network/gocuke. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Beta Readiness
Primary Objective: state machine stability
bytesfields have a 255 byte limit? Decision: length-prefix with a varint to not panic, create a follow-up to allow ordered bytes fields as a future protobuf optionuint32,uint64parameters chosen in feat(orm)!: ordered variable length encoding for uint32 and uint64 types #11090 good to stick with? Decision: this is fine for now, create a follow-up for a protobuf option to optimize for small numberscosmos.orm.v1alpha1->cosmos.orm.v1RC Readiness
EntryCodecio.Closerusage?The text was updated successfully, but these errors were encountered: