Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support importing private keys in hex format #17195

Closed
zakir-code opened this issue Jul 30, 2023 · 3 comments · Fixed by #17424
Closed

[Feature]: Support importing private keys in hex format #17195

zakir-code opened this issue Jul 30, 2023 · 3 comments · Fixed by #17424
Labels
C:Keys Keybase, KMS and HSMs S:zondax Squad: Zondax T:feature-request

Comments

@zakir-code
Copy link
Contributor

zakir-code commented Jul 30, 2023

Summary

Add support for importing private keys in hex format in <app> keys import

Problem Definition

why

  • General wallets support the export of hex type private keys, but not necessarily armor.
  • The user may only want to import a single private key instead of the mnemonic, and then this private key may come from a wallet such as kepler.

disadvantages

  • May not be compatible with importing different types of keys(e.g. ethsecp256k1).

Proposal

@ainhoa-a ainhoa-a added C:Keys Keybase, KMS and HSMs S:zondax Squad: Zondax labels Aug 10, 2023
@bizk
Copy link
Contributor

bizk commented Aug 14, 2023

it makes sense to translate it from hex, I'm wondering if we receive other metadata from such wallets to infer what type of key is being decoded.

We might want to export keys to hex as well

@zakir-code
Copy link
Contributor Author

  1. I think the "--key-type" flag can be added to distinguish the type of private key
  2. Currently supported: simd keys export <name> --unarmored-hex --unsafe

@JulianToledano
Copy link
Contributor

We might want to export keys to hex as well

Thats already possible with the export command. Flags --unsafe and --unarmored-hex are needed. Example:
./simd keys export myKeyUid --unsafe --unarmored-hex

@julienrbrt julienrbrt linked a pull request Aug 17, 2023 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Keys Keybase, KMS and HSMs S:zondax Squad: Zondax T:feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants