Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import hex keys #17424

Merged
merged 11 commits into from
Aug 17, 2023
Merged

feat: import hex keys #17424

merged 11 commits into from
Aug 17, 2023

Conversation

JulianToledano
Copy link
Contributor

Description

Closes:
#17195

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JulianToledano JulianToledano requested a review from a team as a code owner August 17, 2023 09:27
@github-actions github-actions bot added C:CLI C:Keys Keybase, KMS and HSMs labels Aug 17, 2023
@julienrbrt julienrbrt linked an issue Aug 17, 2023 that may be closed by this pull request
[Feature]: Support importing private keys in hex format #17195
Closed
julienrbrt
julienrbrt reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

client/keys/import.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! One nit.

client/keys/import.go Outdated

func ImportKeyHexCommand() *cobra.Command {
return &cobra.Command{
Use: "import-hex <name> <hex> <key-type>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is a better UX if the 3rd argument is optional and have a default algo string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, completely agree!! nice catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key-type is now a flag with secp256k1 as default value

@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Aug 17, 2023
@julienrbrt
Copy link
Member

Can you make the linter happy? https://github.com/cosmos/cosmos-sdk/actions/runs/5890287333/job/15975092543?pr=17424 You need to run make lint-fix.

@julienrbrt julienrbrt mentioned this pull request Aug 17, 2023
Merged
20 tasks
testinginprod
testinginprod approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt added this pull request to the merge queue Aug 17, 2023
Merged via the queue into cosmos:main with commit 0e05785 Aug 17, 2023
43 of 44 checks passed
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
@JulianToledano @mergify
feat: import hex keys (#17424)
a2a0cb9 
(cherry picked from commit 0e05785)
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
@JulianToledano @mergify
feat: import hex keys (#17424)
305c0ab 
(cherry picked from commit 0e05785)

# Conflicts:
#	CHANGELOG.md
#	crypto/keyring/keyring.go
#	crypto/keyring/keyring_test.go
This was referenced Aug 17, 2023
Merged
Merged
julienrbrt pushed a commit that referenced this pull request Aug 17, 2023
@mergify @JulianToledano
feat: import hex keys (backport #17424) (#17432)
0fc0ed5 
Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com>
julienrbrt added a commit that referenced this pull request Aug 17, 2023
@mergify @JulianToledano @julienrbrt
feat: import hex keys (backport #17424) (#17433)
612f0fe 
Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@JulianToledano JulianToledano deleted the feat/hex-keys-import branch August 17, 2023 20:24
samricotta pushed a commit that referenced this pull request Aug 19, 2023
@JulianToledano @samricotta
feat: import hex keys (#17424)
10b23d6
@PoisonPhang PoisonPhang mentioned this pull request Sep 12, 2023
Merged
@ItayLevyOfficial ItayLevyOfficial mentioned this pull request Oct 23, 2023
Closed
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski kocubinski approved these changes

@facundomedica facundomedica facundomedica approved these changes

@testinginprod testinginprod testinginprod approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees

@facundomedica facundomedica

@testinginprod testinginprod

Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:Keys Keybase, KMS and HSMs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Support importing private keys in hex format
5 participants
@JulianToledano @julienrbrt @kocubinski @facundomedica @testinginprod