Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.43 Release QA #9116

Closed
34 of 42 tasks
aaronc opened this issue Apr 14, 2021 · 13 comments · Fixed by #9931
Closed
34 of 42 tasks

v0.43 Release QA #9116

aaronc opened this issue Apr 14, 2021 · 13 comments · Fixed by #9931
Assignees
Milestone

Comments

@aaronc
Copy link
Member

aaronc commented Apr 14, 2021

v0.43 Release team: @AmauryM @robert-zaremba @cyberbono3

After an AIB<>Regen sync last week, here's the outline of the release QA checklist for 0.43. The bullet items are overall in chronological order.

beta releases

  • Tag beta0 off master.
  • Between the beta and rc releases, we freeze the master branch from any kind of state-breaking changes. Client-breaking changes and small API-breaking changes can still be merged into master.
  • Run cloud simulations (AIB to help with this task)
  • Run devnets & testnets Beta & RC Testing Ops #9129
    • All features and fixes in the Unreleased section of the Changelog should be tested.
    • Test migration of existing state to new state.
    • TODO Subsection to be filled with external orgs & chains committing to test the beta release
  • Note: Multiple beta releases can be tagged (always off master) if needed.
  • Note: what we did in Stargate v0.40's rc* releases (which took 3 months...) should be done in this beta phase.

0.43-beta test net and simulation

rc releases

  • Unless there's a strong requirement otherwise, release/v0.43.x should be focused on bugfixes and final polishes. PRs are to be merged into master and backported to release/v0.43.x. Client-breaking changes and small API-breaking changes can still be merged back into the release branch if deemed necessary.
  • Audit Changelog against commit log, ensuring all breaking changes, bug fixes, and improvements are properly documented.
  • chore: Create v0.43.0-rc0 section in CHANGELOG #9572 @AmauryM Add a 0.43.0-rc0 section on master's CHANGELOG
  • @AmauryM Create a release/v0.43.x branch off master.
  • chore: Add release notes for 0.43.0-rc0 #9584 @AmauryM Write RELEASE_NOTES.md
  • @ryanchristo Tag off rc0 from the release branch.
  • Run cloud simulations (AIB to help with this task)
  • Run devnets & testnets Beta & RC Testing Ops #9129
    • All features and fixes in the rc section of the Changelog should be tested.
    • Test migration of existing state to new state.
    • TODO Subsection to be filled with external orgs & chains committing to test the beta release
  • Note: Multiple rc releases can be tagged if needed.
  • In the case where both following conditions are met: 1/ a significant number of PRs are merged into master between two RC releases and 2/ none of those PRs are state-breaking; then the release team can decide to reset --hard the release/v0.43.x branch to point to master.

v0.43.0 release

@aaronc aaronc added backlog Type: QA Quality Assurance labels Apr 14, 2021
@aaronc aaronc added this to the v0.43 milestone Apr 14, 2021
@clevinson
Copy link
Contributor

@AmauryM can you provide an update from your recent call with AiB?

@clevinson
Copy link
Contributor

We should add in here also a description of what testnets we expect from which orgs & chains.

@amaury1093
Copy link
Contributor

amaury1093 commented Apr 19, 2021

I modified the 1st post to reflect the current v0.43 QA & release process. LMK if you have feedback @robert-zaremba @aaronc @clevinson, or feel free to modify that post yourselves too

@aaronc
Copy link
Member Author

aaronc commented Apr 19, 2021

@AmauryM here are the release QA checklist items I had written up before: regen-network/regen-ledger#253 (comment). I think there's a couple things from there to add here. Also, I think we should do a similar API change audit as with new modules - i.e. are new changes well named and complete, etc.

@amaury1093
Copy link
Contributor

Updated!

@aaronc
Copy link
Member Author

aaronc commented Apr 27, 2021

Any update on the timing of this? Seems like the feegrant and authz changes are proceeding relatively swiftly. We should try to get the API level release audit done ASAP because that is now the main thing blocking a beta.

@aaronc aaronc added ready and removed backlog Type: QA Quality Assurance labels Apr 27, 2021
@amaury1093
Copy link
Contributor

amaury1093 commented Apr 28, 2021

I created #9218, mostly copy/pasting items from the readiness checklist we have for authz/feegrant. We can start assigning items within subteams.

@robert-zaremba
Copy link
Collaborator

@aaronc - I've reformatted the Description: added headers, and added a section about 0.43-beta test nets.

@tac0turtle
Copy link
Member

Can we create a branch for 0.43 off of master already? A two-month feature freeze when new features and API changes are constantly coming slows down development quite heavily.

@robert-zaremba
Copy link
Collaborator

Based on previous discussions - we want to keep focus on the release. The release branch will be created when we will release RC. This helps also with stability and bug fixing in master, and reduces efforts related to backporting.

@michaelfig
Copy link
Contributor

We should add in here also a description of what testnets we expect from which orgs & chains.

Agoric will be using 0.43 (beta or RC, whichever is available) for the next phase of our incentivised testnet two weeks from now, with manual testing of our features until that happens.

@amaury1093
Copy link
Contributor

Latest update: rc0 is released!

mergify bot pushed a commit that referenced this issue Jul 2, 2021
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

ref: #9116 
Audit of all commits, and adding a Changelog entry where deemed necessary
- [x] from April 11th to June 28th
- [x] from Feb 23rd to April 10th
- [x] from Jan 7th to Feb 22nd

depends on:
- [x] #9591 to test mergify

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
mergify bot pushed a commit that referenced this issue Jul 2, 2021
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

ref: #9116
Audit of all commits, and adding a Changelog entry where deemed necessary
- [x] from April 11th to June 28th
- [x] from Feb 23rd to April 10th
- [x] from Jan 7th to Feb 22nd

depends on:
- [x] #9591 to test mergify

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 8297f2f)

# Conflicts:
#	CHANGELOG.md
amaury1093 added a commit that referenced this issue Jul 5, 2021
* chore: Audit v0.43 CHANGELOG against commit log (#9592)

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

ref: #9116
Audit of all commits, and adding a Changelog entry where deemed necessary
- [x] from April 11th to June 28th
- [x] from Feb 23rd to April 10th
- [x] from Jan 7th to Feb 22nd

depends on:
- [x] #9591 to test mergify

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 8297f2f)

# Conflicts:
#	CHANGELOG.md

* Conflicts

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
@amaury1093
Copy link
Contributor

v0.43.0 released! The last item is to update the STABLE_RELEASES doc.

mergify bot pushed a commit that referenced this issue Aug 11, 2021
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

ref: #9116 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this issue Oct 12, 2021
cosmos#9622)

* chore: Audit v0.43 CHANGELOG against commit log (cosmos#9592)

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

ref: cosmos#9116
Audit of all commits, and adding a Changelog entry where deemed necessary
- [x] from April 11th to June 28th
- [x] from Feb 23rd to April 10th
- [x] from Jan 7th to Feb 22nd

depends on:
- [x] cosmos#9591 to test mergify

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 8297f2f)

# Conflicts:
#	CHANGELOG.md

* Conflicts

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this issue Nov 1, 2021
cosmos#9622)

* chore: Audit v0.43 CHANGELOG against commit log (cosmos#9592)

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

ref: cosmos#9116
Audit of all commits, and adding a Changelog entry where deemed necessary
- [x] from April 11th to June 28th
- [x] from Feb 23rd to April 10th
- [x] from Jan 7th to Feb 22nd

depends on:
- [x] cosmos#9591 to test mergify

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 8297f2f)

# Conflicts:
#	CHANGELOG.md

* Conflicts

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants