Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added description of how to run the unsafe-reset-all command in simapp README #11718

Merged
merged 3 commits into from
Apr 21, 2022
Merged

fix: Added description of how to run the unsafe-reset-all command in simapp README #11718

merged 3 commits into from
Apr 21, 2022

Conversation

takapi327
Copy link
Contributor

Description

Issues: #11717

The method of executing the unsafe-reset-all command was changed in v0.45.3, but it did not seem to be reflected in the README.

Edited to show commands to be executed in v0.45.3 or later and earlier.

https://github.com/cosmos/cosmos-sdk/blob/v0.45.3/CHANGELOG.md

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

julienrbrt
julienrbrt reviewed Apr 21, 2022
View reviewed changes
simapp/README.md Outdated
@@ -16,7 +16,7 @@ in this testnet.
`simd` binary inside a new `build` directory. The following instructions are run from inside
the `build` directory.
2. If you've run `simd` before, you may need to reset your database before starting a new
testnet. You can reset your database with the following command: `$ ./simd unsafe-reset-all`.
testnet. You can reset your database with the following command: `$ ./simd tendermint unsafe-reset-all`. * If you are using a version earlier than v0.45.3, it will be `$ ./simd unsafe-reset-all`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @takapi327!

Given that we are using version control, I don't think we need to explain the old way to run unsafe-reset-all.
If you are using an older version, you can always find the older command in the changelog or checkout the version tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrbrt
Thank you!
You're absolutely right!
Removed description of the old way to run unsafe-reset-all.

julienrbrt
julienrbrt approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @takapi327!

@julienrbrt julienrbrt added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels Apr 21, 2022
@julienrbrt julienrbrt merged commit d5e0b86 into cosmos:master Apr 21, 2022
@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.45.x release/v0.46.x

mergify bot pushed a commit that referenced this pull request Apr 21, 2022
@takapi327
fix: Added description of how to run the unsafe-reset-all command in …
ba70243 
…simapp README (#11718)

* Fix simapp README

* Revised review content

Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit d5e0b86)
@mergify mergify bot mentioned this pull request Apr 21, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

backport release/v0.45.x release/v0.46.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 21, 2022
@takapi327
fix: Added description of how to run the unsafe-reset-all command in …
a7b4d70 
…simapp README (#11718)

* Fix simapp README

* Revised review content

Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit d5e0b86)
@mergify mergify bot mentioned this pull request Apr 21, 2022
Merged
alexanderbez pushed a commit that referenced this pull request Apr 21, 2022
@mergify
fix: Added description of how to run the unsafe-reset-all command in …
ba127c2 
…simapp README (#11718) (#11720)
tac0turtle pushed a commit that referenced this pull request Apr 22, 2022
@mergify @takapi327
fix: Added description of how to run the unsafe-reset-all command in …
53396c8 
…simapp README (#11718) (#11719)

* Fix simapp README

* Revised review content

Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit d5e0b86)

Co-authored-by: Takahiko Tominaga <57429437+takapi327@users.noreply.github.com>
dwedul-figure added a commit to provenance-io/cosmos-sdk that referenced this pull request May 19, 2022
@dwedul-figure @jhernandezb
@mergify @danburck @fedekunze @alexanderbez @takapi327 @tac0turtle
Merge v0.45.4 into PIO 0.45.x (#127)
9b10c37 
* check error returned from NewNode (cosmos#11624)

* docs: Add v0.45.x to docs versions (backport cosmos#11613) (cosmos#11623)

* docs: Update mentions of Starport to Ignite CLI (backport cosmos#11612) (cosmos#11617)

* feat: add (re)delegation getters (backport cosmos#11596) (cosmos#11615)

* feat: add (re)delegation getters (cosmos#11596)

### Description

This PR adds general helper functions to the `x/staking` module that are used in the Evmos `x/vesting` module and originated from Agoric's custom staking module implementation https://github.com/agoric-labs/cosmos-sdk/blob/4085-true-vesting/x/staking/keeper/delegation.go.

- `GetDelegatorUnbonding`
- `GetDelegatorBonded`
- `IterateDelegatorUnbondingDelegations`
- `IterateDelegatorDelegations`
- `IterateDelegatorRedelegations`

(cherry picked from commit b8270fc)

# Conflicts:
#	CHANGELOG.md
#	x/staking/keeper/delegation.go

* fix RemoveDelegation method conflict

* fix CHANGELOG conflict

* add new PR in CHANGELOG

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* feat: add vesting util functions (backport cosmos#11652) (cosmos#11667)

* feat: add vesting util functions (cosmos#11652)

* feat: add vesting util functions

* changelog

* revert string deletion

* fix build

* Update x/auth/vesting/types/period.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit c676952)

# Conflicts:
#	CHANGELOG.md
#	x/auth/vesting/types/period.go

* changelog

* Update x/auth/vesting/types/period.go

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

* chore: v0.45.x bump min go version to 1.17 (cosmos#11686)

* fix: Add validation on create gentx (backport cosmos#11693) (cosmos#11698)

* fix: Added description of how to run the unsafe-reset-all command in simapp README (cosmos#11718) (cosmos#11719)

* Fix simapp README

* Revised review content

Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit d5e0b86)

Co-authored-by: Takahiko Tominaga <57429437+takapi327@users.noreply.github.com>

* chore: remove unneeded swagger docs from 0.45 cosmos#11745

* fix: data race issues with api.Server (backport cosmos#11724) (cosmos#11748)

* updates (cosmos#11750)

* updates (cosmos#11752)

* chore: release notes++

* Add dynamic build tag so this can build on M1 macs.

* Change README line endings to dos since that's what they were originally.

Co-authored-by: Jorge Hernandez <3452489+jhernandezb@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Takahiko Tominaga <57429437+takapi327@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Jul 7, 2022
@mergify @takapi327 @JimLarson
fix: Added description of how to run the unsafe-reset-all command in …
c0b5012 
…simapp README (cosmos#11718) (cosmos#11719)

* Fix simapp README

* Revised review content

Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit d5e0b86)

Co-authored-by: Takahiko Tominaga <57429437+takapi327@users.noreply.github.com>
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
@mergify @takapi327 @randy75828
fix: Added description of how to run the unsafe-reset-all command in …
1a83efe 
…simapp README (cosmos#11718) (cosmos#11719)

* Fix simapp README

* Revised review content

Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit d5e0b86)

Co-authored-by: Takahiko Tominaga <57429437+takapi327@users.noreply.github.com>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@takapi327 @julienrbrt
fix: Added description of how to run the unsafe-reset-all command in …
05d33a0 
…simapp README (cosmos#11718)

* Fix simapp README

* Revised review content

Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@atheeshp atheeshp atheeshp approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees

@atheeshp atheeshp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takapi327 @julienrbrt @atheeshp