Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve error messages #11762

Merged
merged 11 commits into from
May 6, 2022
Merged

refactor: improve error messages #11762

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7583534
imp: improve error messages
fedekunze Apr 25, 2022
0d1567b
update
fedekunze Apr 25, 2022
c06d20c
Merge branch 'main' into fedekunze/errors
fedekunze Apr 25, 2022
994fcc6
suggestions
fedekunze Apr 28, 2022
f23bc69
Merge branch 'main' into fedekunze/errors
fedekunze Apr 28, 2022
5eb2c47
Merge branch 'main' into fedekunze/errors
alexanderbez Apr 28, 2022
50faf59
Merge branch 'main' into fedekunze/errors
tac0turtle Apr 29, 2022
47a7276
Merge branch 'main' into fedekunze/errors
alexanderbez Apr 29, 2022
f12c5ab
Merge branch 'main' into fedekunze/errors
anilcse May 2, 2022
c1e3a44
Merge branch 'main' into fedekunze/errors
julienrbrt May 6, 2022
7f39d82
implement feedback
julienrbrt May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion errors/abci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func errIsNil(err error) bool {
return false
}

var errPanicWithMsg = Wrapf(ErrPanic, "panic message redacted to hide potentially sensitive system info")
var errPanicWithMsg = Wrapf(ErrPanic, "error message redacted to hide potential sensitive info. Use the '--trace' flag if you are running a node to see the full stack trace error")
fedekunze marked this conversation as resolved.
Show resolved Hide resolved

// Redact replaces an error that is not initialized as an ABCI Error with a
// generic internal error instance. If the error is an ABCI Error, that error is
Expand Down
10 changes: 5 additions & 5 deletions types/decimal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ func NewDecFromIntWithPrec(i Int, prec int64) Dec {
// CONTRACT - This function does not mutate the input str.
func NewDecFromStr(str string) (Dec, error) {
if len(str) == 0 {
return Dec{}, ErrEmptyDecimalStr
return Dec{}, fmt.Errorf("%w: %s", ErrEmptyDecimalStr, str)
fedekunze marked this conversation as resolved.
Show resolved Hide resolved
}

// first extract any negative symbol
Expand All @@ -149,7 +149,7 @@ func NewDecFromStr(str string) (Dec, error) {
}

if len(str) == 0 {
return Dec{}, ErrEmptyDecimalStr
return Dec{}, fmt.Errorf("%w: %s", ErrEmptyDecimalStr, str)
fedekunze marked this conversation as resolved.
Show resolved Hide resolved
}

strs := strings.Split(str, ".")
Expand All @@ -167,7 +167,7 @@ func NewDecFromStr(str string) (Dec, error) {
}

if lenDecs > Precision {
return Dec{}, fmt.Errorf("invalid precision; max: %d, got: %d", Precision, lenDecs)
return Dec{}, fmt.Errorf("value '%s' exceeds max precision by %d decimal places: max precision %d", str, Precision-lenDecs, Precision)
}

// add some extra zero's to correct to the Precision factor
Expand All @@ -177,10 +177,10 @@ func NewDecFromStr(str string) (Dec, error) {

combined, ok := new(big.Int).SetString(combinedStr, 10) // base 10
if !ok {
return Dec{}, fmt.Errorf("failed to set decimal string: %s", combinedStr)
return Dec{}, fmt.Errorf("failed to set decimal string with base 10: %s", combinedStr)
}
if combined.BitLen() > maxDecBitLen {
return Dec{}, fmt.Errorf("decimal out of range; bitLen: got %d, max %d", combined.BitLen(), maxDecBitLen)
return Dec{}, fmt.Errorf("decimal '%s' out of range; bitLen: got %d, max %d", str, combined.BitLen(), maxDecBitLen)
}
if neg {
combined = new(big.Int).Neg(combined)
Expand Down