Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container)!: fix issue providing a module-scoped dep from a module #11913

Merged
merged 2 commits into from
May 9, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented May 9, 2022

Description

Uncovered in #11900.

Also adds the new type OwnModuleKey for a module to retrieve its own module key rather than providing a module-scoped dependency to other modules.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc requested a review from a team as a code owner May 9, 2022 16:04
@github-actions github-actions bot added the C:depinject Issues and PR related to depinject label May 9, 2022
@aaronc aaronc changed the title fix!(container): fix issue with providing a module-scoped dependency … fix!(container): fix issue providing a module-scoped dep from a module May 9, 2022
@aaronc aaronc changed the title fix!(container): fix issue providing a module-scoped dep from a module fix(container)!: fix issue providing a module-scoped dep from a module May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #11913 (322fca9) into main (10af6f9) will increase coverage by 0.02%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11913      +/-   ##
==========================================
+ Coverage   66.25%   66.28%   +0.02%     
==========================================
  Files         689      689              
  Lines       72196    72211      +15     
==========================================
+ Hits        47835    47862      +27     
+ Misses      21645    21629      -16     
- Partials     2716     2720       +4     
Impacted Files Coverage Δ
container/module_key.go 100.00% <ø> (ø)
container/container.go 83.33% <56.25%> (-1.43%) ⬇️
x/group/keeper/keeper.go 55.04% <0.00%> (+0.42%) ⬆️
x/distribution/simulation/operations.go 90.27% <0.00%> (+9.72%) ⬆️

@alexanderbez alexanderbez merged commit 624539a into main May 9, 2022
@alexanderbez alexanderbez deleted the aaronc/fix-container-module-dep branch May 9, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:depinject Issues and PR related to depinject
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants