Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core module with app config support #11914

Merged
merged 11 commits into from
May 10, 2022
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented May 9, 2022

Description

Ref: #11899

This initializes app wiring officially in the SDK by adding the cosmossdk.io/core go module with two packages:

  • appmodule for registering module implementations
  • appconfig for loading declarative app configs

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc marked this pull request as ready for review May 9, 2022 18:02
@aaronc aaronc requested a review from a team as a code owner May 9, 2022 18:02
@aaronc aaronc removed the C:x/auth label May 9, 2022
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid!

gopkg.in/yaml.v2 v2.4.0 // indirect
)

replace github.com/cosmos/cosmos-sdk/api => ../api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll update this once we update the api module vanity URL and tag it.

@alexanderbez alexanderbez self-assigned this May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #11914 (a56f286) into main (40b5953) will decrease coverage by 0.25%.
The diff coverage is 79.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11914      +/-   ##
==========================================
- Coverage   66.30%   66.04%   -0.26%     
==========================================
  Files         689      676      -13     
  Lines       72303    71346     -957     
==========================================
- Hits        47943    47124     -819     
+ Misses      21635    21538      -97     
+ Partials     2725     2684      -41     
Impacted Files Coverage Δ
core/appconfig/config.go 79.68% <79.68%> (ø)
container/struct_args.go
container/one_per_module.go
container/build.go
container/container.go
container/option.go
container/simple.go
container/module_dep.go
container/group.go
container/debug.go
... and 5 more

Copy link
Contributor

@JeancarloBarrios JeancarloBarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@aaronc aaronc merged commit 90272e3 into main May 10, 2022
@aaronc aaronc deleted the aaronc/create-core-module branch May 10, 2022 18:41
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants