Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove RandomizedParams from the AppModuleSimulation interface #12846

Merged
merged 8 commits into from
Aug 10, 2022
Merged

feat: Remove RandomizedParams from the AppModuleSimulation interface #12846

merged 8 commits into from
Aug 10, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #12497

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review August 8, 2022 11:38
@likhita-809 likhita-809 requested a review from a team as a code owner August 8, 2022 11:38
tac0turtle
tac0turtle reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a changelog and upgrading doc entry

alexanderbez
alexanderbez approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented Aug 10, 2022 •
edited
Loading

Codecov Report

Merging #12846 (beb3801) into main (f7e46ae) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12846   +/-   ##
=======================================
  Coverage   56.18%   56.19%           
=======================================
  Files         644      644           
  Lines       54933    54901   -32     
=======================================
- Hits        30866    30849   -17     
+ Misses      21577    21562   -15     
  Partials     2490     2490
Impacted Files Coverage Δ
simapp/utils.go 21.91% <ø> (+0.29%) ⬆️
types/module/simulation.go 0.00% <ø> (ø)
x/auth/module.go 53.42% <ø> (+1.42%) ⬆️
x/authz/module/module.go 17.94% <ø> (+0.44%) ⬆️
x/bank/module.go 65.04% <ø> (+1.23%) ⬆️
x/capability/module.go 66.19% <ø> (+1.81%) ⬆️
x/distribution/module.go 64.28% <ø> (+1.28%) ⬆️
x/evidence/module.go 47.22% <ø> (+1.27%) ⬆️
x/feegrant/module/module.go 15.00% <ø> (+0.36%) ⬆️
x/group/module/module.go 51.89% <ø> (+1.28%) ⬆️
... and 6 more

@tac0turtle tac0turtle merged commit 7496aa3 into main Aug 10, 2022
@tac0turtle tac0turtle deleted the likhita/remove-randomizedParams branch August 10, 2022 12:34
@aljo242 aljo242 mentioned this pull request Aug 12, 2022
Open
@yihuang yihuang mentioned this pull request Aug 31, 2022
Merged
@colin-axner colin-axner mentioned this pull request Feb 15, 2023
Closed
3 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@likhita-809 @tac0turtle
feat: Remove RandomizedParams from the AppModuleSimulation interf…
ebf1292 
…ace (cosmos#12846)

* remove RandomizedParams from AppModuleSimulation interface

* add changelog

* add upgrading doc

* nit fix

Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilcse anilcse anilcse approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@atheeshp atheeshp atheeshp approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@julienrbrt julienrbrt Awaiting requested review from julienrbrt julienrbrt is a code owner

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

Assignees
No one assigned
Labels
C:x/auth C:x/authz C:x/bank C:x/capability C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/slashing C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove RandomizedParams from the AppModuleSimulation interface.
5 participants
@likhita-809 @anilcse @alexanderbez @tac0turtle @atheeshp