Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: x/gov/client/cli: update & tighten Prompt.Parse tests #13350

Merged
merged 3 commits into from
Sep 21, 2022
Merged

fix: x/gov/client/cli: update & tighten Prompt.Parse tests #13350

merged 3 commits into from
Sep 21, 2022

Commits on Sep 21, 2022

  1. fix: x/gov/client/cli: use strconv.ParseInt, update & tighten Prompt.… 

    …Parse tests

Uses strconv.ParseInt(s, 10, 0) where 0 as the bitSize lets
the system determine the bitSize to parse int into its range.
Adds more rigorous checks to ensure that the output
is as expected with range failures. While here also
added control tests to ensure that we can parse integers
within range of int.

Updates #13346
    @odeke-em
    odeke-em committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    d4952dc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into x-gov-fix-tests

    @odeke-em
    odeke-em committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    b7d7275 View commit details
    Browse the repository at this point in the history

  3. fix assert message

    @julienrbrt
    julienrbrt committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    0a69dac View commit details
    Browse the repository at this point in the history