feat!: specify module to export #13437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: @czarcas7ic <czarcas7ic@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13437 +/- ##
==========================================
- Coverage 54.10% 53.84% -0.27%
==========================================
Files 647 651 +4
Lines 55278 56386 +1108
==========================================
+ Hits 29910 30362 +452
- Misses 22970 23598 +628
- Partials 2398 2426 +28
|
julienrbrt
commented
Oct 3, 2022
types/module/module.go
Outdated
| } | ||
| } else { | ||
| // verify modules exists in app, so that we don't panic in the middle of an export | ||
| if err := m.checkModulesExists(modulesToExport); err != nil { |
There was a problem hiding this comment.
Unfortunately, we cannot return a nice error in ExportCmd as we don't have any information about the app. This does the job.
alexanderbez
changed the title
alexanderbez
reviewed
Oct 3, 2022
tac0turtle
reviewed
Oct 3, 2022
tac0turtle
added
the
T: API Breaking
Added. |
tac0turtle
approved these changes
Oct 3, 2022
alexanderbez
approved these changes
Oct 3, 2022
21 tasks
Wryhder
pushed a commit
to Wryhder/cosmos-sdk
that referenced
this pull request
Oct 26, 2022
Cashmaney
pushed a commit
to scrtlabs/cosmos-sdk
that referenced
this pull request
Nov 29, 2022
Cashmaney
added a commit
to scrtlabs/cosmos-sdk
that referenced
this pull request
Jan 17, 2023
feat!: specify module to export (cosmos#13437)
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upstreams osmosis-labs#336 with extra checks.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change