Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent simple inclusion of a valid mnemonic #13670

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

arirubinstein
Copy link
Contributor

@arirubinstein arirubinstein commented Oct 26, 2022

Description

Ref: #9122

This PR adds a validation check to prevent simple inclusion of a valid mnemonic in a tx by adding a validation to the tx factory.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@arirubinstein arirubinstein requested a review from a team as a code owner October 26, 2022 18:30
@github-actions github-actions bot added the C:CLI label Oct 26, 2022
@arirubinstein arirubinstein force-pushed the mnemonic_tx branch 2 times, most recently from 5bd6220 to d84fa58 Compare October 26, 2022 18:35
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, I didn't know it was a thing 😂

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #13670 (a5fe7df) into main (6b4db20) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13670      +/-   ##
==========================================
+ Coverage   54.80%   54.92%   +0.12%     
==========================================
  Files         647      656       +9     
  Lines       55794    56202     +408     
==========================================
+ Hits        30579    30871     +292     
- Misses      22724    22807      +83     
- Partials     2491     2524      +33     
Impacted Files Coverage Δ
client/tx/factory.go 29.21% <100.00%> (+0.80%) ⬆️
x/group/keeper/keeper.go 56.25% <0.00%> (-0.40%) ⬇️
tx/textual/valuerenderer/timestamp.go 89.28% <0.00%> (ø)
tx/textual/valuerenderer/bytes.go 62.50% <0.00%> (ø)
tx/textual/valuerenderer/valuerenderer.go 72.41% <0.00%> (ø)
tx/textual/valuerenderer/string.go 66.66% <0.00%> (ø)
tx/textual/valuerenderer/coins.go 73.17% <0.00%> (ø)
tx/textual/valuerenderer/duration.go 78.22% <0.00%> (ø)
tx/textual/valuerenderer/message.go 64.22% <0.00%> (ø)
tx/textual/valuerenderer/dec.go 50.00% <0.00%> (ø)
... and 1 more

@tac0turtle
Copy link
Member

This is awesome thank you!!

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't even think of this! Neat :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants