Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not shadow clientCtx in start.go #14086

Merged
merged 3 commits into from
Nov 30, 2022
Merged

fix: do not shadow clientCtx in start.go #14086

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df960b7
fix: do not shadow clientCtx in start.go
julienrbrt Nov 30, 2022
1824235
Merge branch 'main' into julien/fix-clientctx
julienrbrt Nov 30, 2022
c239122
Merge branch 'main' into julien/fix-clientctx
julienrbrt Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,9 @@ func startInProcess(ctx *Context, clientCtx client.Context, appCreator types.App
// service if API or gRPC is enabled, and avoid doing so in the general
// case, because it spawns a new local tendermint RPC client.
if (config.API.Enable || config.GRPC.Enable) && tmNode != nil {
clientCtx := clientCtx.WithClient(local.New(tmNode))
// re-assign for making the client available below
// do not use := to avoid shadowing clientCtx
clientCtx = clientCtx.WithClient(local.New(tmNode))

app.RegisterTxService(clientCtx)
app.RegisterTendermintService(clientCtx)
Expand Down