Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return undelegate amount with MsgUndelegateResponse #14590

Merged
merged 18 commits into from
Jan 23, 2023
Merged

fix: return undelegate amount with MsgUndelegateResponse #14590

merged 18 commits into from
Jan 23, 2023

Conversation

0xmuralik
Copy link
Contributor

Description

Closes: #14153

Return undelegated amount after initating undelegation.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@0xmuralik 0xmuralik requested a review from a team as a code owner January 12, 2023 11:37
julienrbrt
julienrbrt reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add test cases and add a changelog?

proto/cosmos/staking/v1beta1/tx.proto Show resolved Hide resolved
@julienrbrt julienrbrt marked this pull request as draft January 12, 2023 11:49
@0xmuralik 0xmuralik marked this pull request as ready for review January 17, 2023 11:37
@0xmuralik 0xmuralik requested review from julienrbrt and removed request for alexanderbez and facundomedica January 17, 2023 11:37
@0xmuralik 0xmuralik requested review from atheeshp and julienrbrt and removed request for julienrbrt and atheeshp January 18, 2023 06:04
@0xmuralik 0xmuralik requested review from atheeshp and removed request for julienrbrt January 18, 2023 06:05
likhita-809
likhita-809 reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits

proto/cosmos/staking/v1beta1/tx.proto Outdated Show resolved Hide resolved
tests/integration/staking/keeper/unbonding_test.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending nits from above.

CHANGELOG.md Show resolved Hide resolved
0xmuralik and others added 3 commits January 18, 2023 15:43
@0xmuralik @likhita-809
fix proto comment
e0abf90 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@0xmuralik @likhita-809
remove comment
1d44bf1 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@0xmuralik
changelog api breaking
0cb6495
@amaury1093 amaury1093 self-assigned this Jan 18, 2023
@amaury1093 amaury1093 added the T: State Machine Breaking State machine breaking changes (impacts consensus). label Jan 18, 2023
amaury1093
amaury1093 reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit to mark it state-machine breaking (I believe).

CHANGELOG.md Show resolved Hide resolved
proto/cosmos/staking/v1beta1/tx.proto Show resolved Hide resolved
@0xmuralik 0xmuralik requested review from amaury1093 and removed request for atheeshp January 20, 2023 10:22
likhita-809
likhita-809 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt enabled auto-merge (squash) January 23, 2023 09:48
@julienrbrt julienrbrt merged commit e3b37dc into cosmos:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@atheeshp atheeshp atheeshp left review comments

@julienrbrt julienrbrt julienrbrt approved these changes

@likhita-809 likhita-809 likhita-809 approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees

@amaury1093 amaury1093

Labels
C:x/auth C:x/staking T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MsgUndelegateResponse should return the actual amount undelegated
6 participants
@0xmuralik @amaury1093 @alexanderbez @julienrbrt @atheeshp @likhita-809