Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rm dependency from x/auth -> x/feegrant #14755

Merged
merged 7 commits into from
Jan 24, 2023

Conversation

kocubinski
Copy link
Member

@kocubinski kocubinski commented Jan 24, 2023

Description

Ref: #14649 (review), #14559

Removes the dependency on x/feegrant from x/auth. This is required for x/feegrant as a go module since it (like most modules) depends on x/auth.

  • Use expected keeper in ante package instead of keeper interface in feegrant
  • Remove unnecessary (or unused) x/feegrant dependencies from test phase.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski marked this pull request as ready for review January 24, 2023 16:35
@kocubinski kocubinski requested a review from a team as a code owner January 24, 2023 16:35
x/auth/ante/feegrant_test.go Outdated Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

"github.com/stretchr/testify/require"
)

func AssertError(t *testing.T, err error, expectedErr error, expectedErrMsg string) {
Copy link
Member

@julienrbrt julienrbrt Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bez meant here: https://github.com/cosmos/cosmos-sdk/blob/main/testutil/assertHelpers.go
If you end up moving this to this file, could you rename that file too :D

@kocubinski kocubinski enabled auto-merge (squash) January 24, 2023 18:37
@kocubinski kocubinski merged commit a16b11d into main Jan 24, 2023
@kocubinski kocubinski deleted the kocubinski/rm-auth-feegrant branch January 24, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants