Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use gov v1 proposals in upgrade cli #14880

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 2, 2023

Description

Notice while doing #14878 that upgrade CLI was not using gov v1.
This upgrades it to gov v1.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

x/upgrade/client/cli/tx.go Fixed Show fixed Hide fixed
x/upgrade/client/cli/tx.go Fixed Show fixed Hide fixed
@julienrbrt julienrbrt changed the title feat: use gov v1 proposals in upgrade cli feat!: use gov v1 proposals in upgrade cli Feb 2, 2023
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Feb 2, 2023
// add common proposal flags
flags.AddTxFlagsToCmd(cmd)
cli.AddGovPropFlagsToCmd(cmd)
cmd.MarkFlagRequired(cli.FlagTitle)

Check warning

Code scanning / gosec

Errors unhandled.

Errors unhandled.
@julienrbrt julienrbrt merged commit 5ec3d2b into main Feb 2, 2023
@julienrbrt julienrbrt deleted the julien/upgrade-gov-v1 branch February 2, 2023 12:55
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:x/gov C:x/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants