Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin gogoproto version in Dockerfile #14999

Closed
wants to merge 1 commit into from

Conversation

kocubinski
Copy link
Member

Description

Locally make proto-gen has begun to fail for me like

19:42 $ make proto-gen 
Generating Protobuf files
Generating gogo proto code
cp: can't stat 'github.com/cosmos/cosmos-sdk/*': No such file or directory
make: *** [Makefile:383: proto-gen] Error 1

So while debugging proto code generation outside of Docker, I've discovered the latest version of cosmos-sdk/gogoproto is incompatible with this line of scripts/protocgen.sh, returning the panic introduced in cosmos/gogoproto#32

panic: file name testdata.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names

goroutine 1 [running]:
github.com/cosmos/gogoproto/protoc-gen-gogo/generator.(*Generator).WrapTypes(0xc0000d7400)
	/home/mtkoan/dev/gogoproto/protoc-gen-gogo/generator/generator.go:806 +0xa25
github.com/cosmos/gogoproto/vanity/command.Generate(0xc00007e240)
	/home/mtkoan/dev/gogoproto/vanity/command/command.go:126 +0x165
main.main()
	/home/mtkoan/dev/gogoproto/protoc-gen-gocosmos/main.go:22 +0x307

The Dockerfile for the proto builder should be updated to clone a tag (not the default branch); this is what I referenced when setting up a local environment.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski requested a review from a team as a code owner February 11, 2023 16:38
@julienrbrt
Copy link
Member

julienrbrt commented Feb 11, 2023

Actually, imho should use the latest I think. I have a fix for the SDK here: #14991.

The version 0.11.6 does not have the latest change, but proto-builder 0.12.0 does (as at docker image building it will always get the latest version)

@kocubinski
Copy link
Member Author

Actually, imho should use the latest I think. I have a fix for the SDK here: #14991.

The version 0.11.6 does not have the latest change, but proto-builder 0.12.0 does (as at docker imagine building it will always get the latest version)

SGTM so long as main is not broken ;)

@julienrbrt
Copy link
Member

Actually, imho should use the latest I think. I have a fix for the SDK here: #14991.

The version 0.11.6 does not have the latest change, but proto-builder 0.12.0 does (as at docker imagine building it will always get the latest version)

SGTM so long as main is not broken ;)

Yes, can you try again now this is merged?

@julienrbrt
Copy link
Member

Closing as it's fixed already 👍🏾

@julienrbrt julienrbrt closed this Feb 11, 2023
@julienrbrt julienrbrt deleted the kocubinski/protobuiler-dockerfile-gogoproto branch February 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants