-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement RegisterServices for CoreAPI in module manager #15133
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
33336d2
feat: Implement RegisterServices for CoreAPI modules
facundomedica 66d05dd
suggestions from Aaron
facundomedica 6a45294
return err
facundomedica 5067402
fix autocli
facundomedica 71963fa
Merge branch 'main' into facu/coreapi-service-2
facundomedica 0b66d23
Merge branch 'main' into facu/coreapi-service-2
facundomedica 66c71ef
Merge branch 'main' into facu/coreapi-service-2
tac0turtle 223cc26
Merge branch 'main' into facu/coreapi-service-2
facundomedica 0fd5a01
Merge branch 'main' into facu/coreapi-service-2
facundomedica 51722d1
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into facu…
facundomedica 550aed9
update to core v0.6.0
facundomedica 24064ca
Merge branch 'facu/coreapi-service-2' of https://github.com/cosmos/co…
facundomedica fe96c15
go mod tidy simapp
facundomedica 109bd53
go mod tidy tests
facundomedica 4edb500
update to use appmodule.HasServices when needed
facundomedica 55df21d
update to use appmodule.HasServices when needed
facundomedica a5dd4c1
Merge branch 'main' into facu/coreapi-service-2
facundomedica 90a6226
Merge branch 'main' into facu/coreapi-service-2
facundomedica d7e3d9c
Merge branch 'main' into facu/coreapi-service-2
facundomedica 49c3a05
Merge branch 'main' into facu/coreapi-service-2
facundomedica 2275d6c
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into facu…
facundomedica 4e86967
de-duplicate code in autocli + correct implementation of the configur…
facundomedica 62b2989
Merge branch 'facu/coreapi-service-2' of https://github.com/cosmos/co…
facundomedica 849416b
Merge branch 'main' into facu/coreapi-service-2
facundomedica eff5ec5
cl++
facundomedica 4a348b2
Merge branch 'facu/coreapi-service-2' of https://github.com/cosmos/co…
facundomedica File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can reduce code duplication a lot here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I've also did the correct implementation of RegisterServices in the autocli configurator. We should be good to merge now 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I've also did the correct implementation of RegisterServices in the autocli configurator. We should be good to merge now 👌