Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add node status endpoint #15597

Merged
merged 18 commits into from
Apr 13, 2023
Merged

feat!: add node status endpoint #15597

merged 18 commits into from
Apr 13, 2023

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Mar 29, 2023

Description

ref: #15463

partially closes #11012

expose more data from the config and parts of state information


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Mar 29, 2023
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @tac0turtle

@tac0turtle
Copy link
Member Author

opening this for review but keeping the issue open as this only solves part of the issue

@tac0turtle tac0turtle marked this pull request as ready for review April 8, 2023 09:02
@tac0turtle tac0turtle requested a review from a team as a code owner April 8, 2023 09:02
@github-actions

This comment has been minimized.

client/grpc/node/service.go Outdated Show resolved Hide resolved
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, qq: are we not returning EarliestStoreHeight for any reason in particular? The ctx.MultiStore() isn't available at the query server?

@tac0turtle
Copy link
Member Author

the way to get the earliest version would have bloated this pr so will do it in a follow up

@tac0turtle tac0turtle enabled auto-merge (squash) April 11, 2023 13:32
CHANGELOG.md Outdated Show resolved Hide resolved
@tac0turtle
Copy link
Member Author

changed the naming and added two more fields of information for go relayer

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 13, 2023
@tac0turtle tac0turtle merged commit 9e4fbb6 into main Apr 13, 2023
@tac0turtle tac0turtle deleted the marko/15463 branch April 13, 2023 13:42
@julienrbrt
Copy link
Member

@tac0turtle the changelogs are under v0.46.x while they both should be under unreleased.

@tac0turtle
Copy link
Member Author

tac0turtle commented Apr 13, 2023

dam not sure how that happened, ill amend

julienrbrt added a commit that referenced this pull request Apr 14, 2023
cool-develope pushed a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPIC: gRPC requirements for IBC relayers
4 participants