Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Better logging for signature verification failure #15867

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

mattverse
Copy link
Contributor

@mattverse mattverse commented Apr 18, 2023

Description

Closes: #XXXX

Upon verifying signatures, we overwrite error messages for legacy amino signers, due to high possibility that sequence number is the potential cause of failure for verifying signature. However, for other cases, we should return error message of why signature verification failed, instead of overwriting the original error message.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mattverse mattverse requested a review from a team as a code owner April 18, 2023 11:47
@mattverse mattverse changed the title misc: Better logging for signature verification failure chore: Better logging for signature verification failure Apr 18, 2023
@mattverse
Copy link
Contributor Author

Wondering if this can be breaking change by any chance 🤔

Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was thinking about this literally 2 days ago. Tysm!
This might be breaking for external tools, although it's on an error case so I doubt it's critical

@julienrbrt julienrbrt added this pull request to the merge queue Apr 18, 2023
Merged via the queue into cosmos:main with commit 33657b3 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants