feat!: Add gas limits to queries #16239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
changed the title
|
Is there a clean way to do a go test, that shows what the error message will be if you do a grpc query that exceeds the gas limit? |
|
We've essentially wrapped up #15519 -- we just need review. I would personally like to see that merged prior to any major baseapp changes, but I'm not opposed to getting this in. |
julienrbrt
reviewed
Jun 2, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
alexanderbez
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
utACK. The approach looks correct to me. I think @julienrbrt had a comment or two. Mind addressing that quickly @ValarDragon?
odeke-em
approved these changes
Aug 6, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
tac0turtle
approved these changes
Aug 7, 2023
tac0turtle
added
the
backport/v0.50.x
julienrbrt
reviewed
Aug 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit dea5b97)
tac0turtle
pushed a commit
that referenced
this pull request
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #16237
Added a baseapp test. Is there anywhere where we test e2e that the new config value is read correctly and passed into baseapp? I didn't see such a test anywhere
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change