Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(misc): remove aliases from types/math.go #16320

Closed
wants to merge 4 commits into from
Closed

refactor(misc): remove aliases from types/math.go #16320

wants to merge 4 commits into from

Conversation

samricotta
Copy link
Contributor

Closes: #14405

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@samricotta samricotta requested a review from a team as a code owner May 28, 2023 18:44
tac0turtle
tac0turtle reviewed May 28, 2023
View reviewed changes
x/gov/abci_test.go
@@ -1,15 +1,15 @@
package gov_test

import (
"github.com/stretchr/testify/require"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we revert this change

@samricotta samricotta marked this pull request as draft May 28, 2023 21:21
tac0turtle
tac0turtle reviewed May 28, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few linting issues otherwise LGTM

julienrbrt
julienrbrt reviewed May 28, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no aliases removed from types/math, is it intended (it doesn't close the issue then)

CHANGELOG.md
@@ -240,6 +240,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* this finalizes the gov collections migration
* Removed: keeper `InsertActiveProposalsQueue`, `RemoveActiveProposalsQueue`, `InsertInactiveProposalsQueue`, `RemoveInactiveProposalsQueue`, `IterateInactiveProposalsQueue`, `IterateActiveProposalsQueue`, `ActiveProposalsQueueIterator`, `InactiveProposalsQueueIterator`
* Remove: types all the key related functions
* (types/math) [#16320](https://github.com/cosmos/cosmos-sdk/pull/16320) Remove aliases from `types/math.go`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, there is one entry already in the changelog.

Suggested change
* (types/math) [#16320](https://github.com/cosmos/cosmos-sdk/pull/16320) Remove aliases from `types/math.go`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this PR number to the existing entry with comma separated?

Copy link
Contributor Author

@samricotta samricotta May 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a draft, will close issue

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jun 30, 2023
@julienrbrt
Copy link
Member

As part of the types audit (#16475 (comment)) I am going to push that to the finish line for avoiding inconsistencies in v0.50.
Closing this because this has a hell of a conflict.

@julienrbrt julienrbrt closed this Jun 30, 2023
@julienrbrt julienrbrt deleted the sam/math-misc branch June 30, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle left review comments

@julienrbrt julienrbrt julienrbrt left review comments

@atheeshp atheeshp atheeshp left review comments

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica will be requested when the pull request is marked ready for review facundomedica is a code owner

@JulianToledano JulianToledano Awaiting requested review from JulianToledano JulianToledano will be requested when the pull request is marked ready for review JulianToledano is a code owner

@ziscky ziscky Awaiting requested review from ziscky ziscky will be requested when the pull request is marked ready for review ziscky is a code owner

@alpe alpe Awaiting requested review from alpe alpe will be requested when the pull request is marked ready for review alpe is a code owner

@lucaslopezf lucaslopezf Awaiting requested review from lucaslopezf lucaslopezf will be requested when the pull request is marked ready for review lucaslopezf is a code owner

@kocubinski kocubinski Awaiting requested review from kocubinski