Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurator config options #16672

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

The more I use the configurator, the more I need it more configurable.
Currently you cannot use it when adding external modules, this PR solves that.

panic: all modules must be defined when setting SetOrderInitGenesis, missing: [example] [recovered]
	panic: all modules must be defined when setting SetOrderInitGenesis, missing: [example]

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 23, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner June 23, 2023 18:41
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt
Copy link
Member Author

julienrbrt commented Jun 23, 2023

Adding the backport label to v0.47 as well and I'll be backporting the two previous PRs about the configurator as well.

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Jun 23, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, we should get rid of this panic imo.

@julienrbrt julienrbrt added this pull request to the merge queue Jun 26, 2023
@julienrbrt julienrbrt removed this pull request from the merge queue due to a manual request Jun 26, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit dcc5afe Jun 26, 2023
50 checks passed
@julienrbrt julienrbrt deleted the julien/configurator-flexible branch June 26, 2023 19:32
mergify bot pushed a commit that referenced this pull request Jun 26, 2023
mergify bot pushed a commit that referenced this pull request Jun 26, 2023
(cherry picked from commit dcc5afe)

# Conflicts:
#	testutil/configurator/configurator.go
@julienrbrt
Copy link
Member Author

utACK, we should get rid of this panic imo.

Mmh, actually the assertion works as intended, I had a module which had an init genesis function defined, but wasn't specified in the OrderInitGenesis, so this is great it panics. The issue was: I couldn't simply add it in the configurator.
Assertions have been loosened for v0.50, where now only necessary modules are required (before it was all modules) -> https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#module-assertions, which is a good ux.

julienrbrt added a commit that referenced this pull request Jun 26, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Jun 26, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants