Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change bank multi-send command description #16950

Merged
merged 3 commits into from
Jul 17, 2023
Merged

docs: change bank multi-send command description #16950

merged 3 commits into from
Jul 17, 2023

Conversation

charymalloju
Copy link
Contributor

@charymalloju charymalloju commented Jul 12, 2023 •
edited by julienrbrt
Loading

Description

Closes: #16948

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@charymalloju charymalloju requested a review from a team as a code owner July 12, 2023 11:57
julienrbrt
julienrbrt reviewed Jul 12, 2023
View reviewed changes
x/bank/client/cli/tx.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jul 12, 2023
@julienrbrt julienrbrt changed the title doc: change bank multi-send command description docs: change bank multi-send command description Jul 12, 2023
julienrbrt
julienrbrt requested changes Jul 17, 2023
View reviewed changes
x/bank/client/cli/tx.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt added this pull request to the merge queue Jul 17, 2023
Merged via the queue into cosmos:main with commit c1f5524 Jul 17, 2023
45 of 46 checks passed
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
@charymalloju @mergify
docs: change bank multi-send command description (#16950)
32ff7aa 
(cherry picked from commit c1f5524)
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
@charymalloju @mergify
docs: change bank multi-send command description (#16950)
2794ac2 
(cherry picked from commit c1f5524)
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
@charymalloju @mergify
docs: change bank multi-send command description (#16950)
9e32879 
(cherry picked from commit c1f5524)
This was referenced Jul 17, 2023
Merged
Merged
Merged
julienrbrt pushed a commit that referenced this pull request Jul 17, 2023
@mergify
docs: change bank multi-send command description (backport #16950) (#…
ede074f 
…17018)
julienrbrt pushed a commit that referenced this pull request Jul 17, 2023
@mergify
docs: change bank multi-send command description (backport #16950) (#…
ffe7a5e 
…17019)
julienrbrt pushed a commit that referenced this pull request Jul 17, 2023
@mergify
docs: change bank multi-send command description (backport #16950) (#…
509a228 
…17017)
cmwaters added a commit to celestiaorg/cosmos-sdk that referenced this pull request Aug 15, 2023
@cmwaters @julienrbrt
@mergify @odeke-em @yihuang @mmsqe @tac0turtle @KyleMoser @rootulp @itsdevbear
chore: bump sdk to v0.46.14 and tm to v1.26.2-tm-v0.34.28 (#340)
64adc6e 
* build(deps): bump cometbft to v0.34.29 (cosmos#16553)

* fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport cosmos#16554) (cosmos#16570)

Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: snapshotter's failure is not propogated (backport cosmos#16588) (cosmos#16604)

Co-authored-by: yihuang <huang@crypto.com>

* feat: add custom max gas for block for sim config (backport cosmos#16656) (cosmos#16731)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* fix: accaddr cachefix (backport cosmos#15433) (cosmos#16823)

Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com>
Co-authored-by: HuangYi <huang@crypto.com>

* fix(cli): improve `prune` command ux (backport cosmos#16856) (cosmos#16876)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: query tx events with `>=` and `<=` operators (cosmos#16994)

* docs: change bank multi-send command description (backport cosmos#16950) (cosmos#17019)

* chore: prepare v0.46.14 (cosmos#16879)

* refactor: add MigrateHandler to allow reuse migrate genesis related function  (backport cosmos#17296) (cosmos#17301)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302)

* feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357)

Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388)

Co-authored-by: Julien Robert <julien@rbrt.fr>

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Devon Bear <itsdevbear@berachain.com>
@faddat faddat mentioned this pull request Sep 5, 2023
Closed
19 tasks
@faddat faddat mentioned this pull request Oct 15, 2023
Closed
19 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez left review comments

@julienrbrt julienrbrt julienrbrt approved these changes

@atheeshp atheeshp atheeshp approved these changes

@likhita-809 likhita-809 likhita-809 approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI C:x/bank
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Bank multi-send not working as expected
5 participants
@charymalloju @alexanderbez @julienrbrt @atheeshp @likhita-809