Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create x/mint Go module #17812

Closed
wants to merge 14 commits into from
Closed

refactor: create x/mint Go module #17812

wants to merge 14 commits into from

Conversation

odeke-em
Copy link
Collaborator

@odeke-em odeke-em commented Sep 19, 2023

This change adds a go.mod file for x/mint to
be spun out as an independent Go module.

Updates #11899
closes #17813

Summary by CodeRabbit

  • Refactor: The x/mint package has been moved to a new location, cosmossdk.io/x/mint, from its previous location, github.com/cosmos/cosmos-sdk/x/mint. This change has been reflected across the project, with all import paths updated accordingly.
  • New Feature: A new job test-x-mint has been added to the GitHub workflow. This job runs tests and performs code coverage analysis for the x/mint package, improving the reliability of the code.
  • Chore: The project now includes a template for a changelog file in the x/mint package, providing a structured way to document changes.
  • Test: Various test files have been updated to reflect the new import paths for the x/mint package, ensuring that the tests remain accurate and up-to-date.

x/mint/go.mod Outdated Show resolved Hide resolved
This change adds a go.mod file for x/mint to
be spun out as an independent Go module.

Updates #11899
Fixes #17813
x/evidence/go.mod Outdated Show resolved Hide resolved
x/feegrant/go.mod Outdated Show resolved Hide resolved
@julienrbrt
Copy link
Member

Agree with Atheesh, let's use the pseudo version from main, even if we have replaces in the module, otherwise it is confusing.

@tac0turtle tac0turtle requested a review from a team as a code owner October 19, 2023 15:19
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2023

Walkthrough

The changes primarily involve a shift in the import paths for the mint package from github.com/cosmos/cosmos-sdk/x/mint to cosmossdk.io/x/mint across multiple files. Additionally, a new field auth has been added to the Mint message, and a new job test-x-mint has been added to the GitHub workflow.

Changes

File(s) Summary
.github/dependabot.yml, .github/workflows/test.yml Added new configurations for the x/mint package.
api/cosmos/mint/module/v1/module.pulsar.go Added a new field auth to the Mint message.
baseapp/*.go, simapp/*.go, tests/*.go, x/*.go Updated import paths for the mint package.
contrib/images/simd-env/Dockerfile, go.work.example Added the x/mint module to the project.
proto/cosmos/mint/*.proto Updated go_package option in the protocol buffer files.
x/mint/CHANGELOG.md Added a template for a changelog file.
x/mint/sonar-project.properties Added SonarQube configuration for the x/mint project.

🐇 "In the land of code, where the shadows lie,

We've moved a package, under a new sky.

From GitHub's realm to Cosmos we go,

With paths updated, in a steady flow.

A new field added, a test job too,

Celebrate these changes, for they are true!" 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 4121869 and 7c101eb.
Files ignored due to filter (30)
  • client/v2/go.mod
  • client/v2/go.sum
  • go.mod
  • go.sum
  • simapp/go.mod
  • simapp/go.sum
  • tests/go.mod
  • tests/go.sum
  • tests/starship/tests/go.mod
  • tests/starship/tests/go.sum
  • x/circuit/go.mod
  • x/circuit/go.sum
  • x/evidence/go.mod
  • x/evidence/go.sum
  • x/feegrant/go.mod
  • x/feegrant/go.sum
  • x/mint/go.mod
  • x/mint/go.sum
  • x/mint/types/genesis.pb.go
  • x/mint/types/mint.pb.go
  • x/mint/types/query.pb.go
  • x/mint/types/tx.pb.go
  • x/nft/go.mod
  • x/nft/go.sum
  • x/params/go.mod
  • x/params/go.sum
  • x/protocolpool/go.mod
  • x/protocolpool/go.sum
  • x/upgrade/go.mod
  • x/upgrade/go.sum
Files selected for processing (57)
  • .github/dependabot.yml (1 hunks)
  • api/cosmos/mint/module/v1/module.pulsar.go (1 hunks)
  • baseapp/block_gas_test.go (2 hunks)
  • baseapp/utils_test.go (2 hunks)
  • contrib/images/simd-env/Dockerfile (1 hunks)
  • go.work.example (1 hunks)
  • proto/cosmos/mint/module/v1/module.proto (1 hunks)
  • proto/cosmos/mint/v1beta1/genesis.proto (1 hunks)
  • proto/cosmos/mint/v1beta1/mint.proto (1 hunks)
  • proto/cosmos/mint/v1beta1/query.proto (1 hunks)
  • proto/cosmos/mint/v1beta1/tx.proto (1 hunks)
  • simapp/app.go (2 hunks)
  • simapp/app_config.go (2 hunks)
  • simapp/app_test.go (2 hunks)
  • simapp/app_v2.go (2 hunks)
  • simapp/simd/cmd/testnet_test.go (2 hunks)
  • simapp/test_helpers.go (2 hunks)
  • tests/e2e/mint/grpc.go (1 hunks)
  • tests/e2e/mint/suite.go (1 hunks)
  • tests/integration/bank/keeper/deterministic_test.go (2 hunks)
  • tests/integration/evidence/keeper/infraction_test.go (2 hunks)
  • tests/integration/gov/keeper/keeper_test.go (2 hunks)
  • tests/integration/gov/module_test.go (1 hunks)
  • tests/integration/rapidgen/rapidgen.go (2 hunks)
  • tests/integration/slashing/keeper/keeper_test.go (2 hunks)
  • tests/integration/staking/keeper/common_test.go (2 hunks)
  • tests/integration/staking/keeper/deterministic_test.go (2 hunks)
  • tests/integration/staking/simulation/operations_test.go (2 hunks)
  • tests/integration/tx/aminojson/aminojson_test.go (2 hunks)
  • tests/integration/tx/decode_test.go (2 hunks)
  • testutil/configurator/configurator.go (1 hunks)
  • testutil/integration/example_test.go (2 hunks)
  • testutil/sims/address_helpers.go (1 hunks)
  • testutil/testnet/genesis.go (2 hunks)
  • x/authz/testutil/app_config.go (2 hunks)
  • x/consensus/testutil/helpers.go (1 hunks)
  • x/distribution/client/cli/tx_test.go (2 hunks)
  • x/distribution/testutil/app_config.go (2 hunks)
  • x/feegrant/simulation/operations_test.go (2 hunks)
  • x/group/keeper/keeper_test.go (2 hunks)
  • x/group/keeper/msg_server_test.go (2 hunks)
  • x/group/testutil/app_config.go (2 hunks)
  • x/mint/CHANGELOG.md (1 hunks)
  • x/mint/abci.go (1 hunks)
  • x/mint/keeper/genesis.go (1 hunks)
  • x/mint/keeper/genesis_test.go (1 hunks)
  • x/mint/keeper/grpc_query.go (1 hunks)
  • x/mint/keeper/grpc_query_test.go (1 hunks)
  • x/mint/keeper/keeper.go (1 hunks)
  • x/mint/keeper/keeper_test.go (1 hunks)
  • x/mint/keeper/msg_server.go (1 hunks)
  • x/mint/keeper/msg_server_test.go (1 hunks)
  • x/mint/module.go (1 hunks)
  • x/mint/module_test.go (1 hunks)
  • x/mint/simulation/genesis.go (1 hunks)
  • x/mint/simulation/genesis_test.go (1 hunks)
  • x/mint/simulation/proposals.go (1 hunks)
Files not processed due to max files limit (7)
  • x/mint/simulation/proposals_test.go
  • x/mint/testutil/app_config.go
  • x/nft/testutil/app_config.go
  • x/protocolpool/testutil/app_config.go
  • x/slashing/simulation/operations_test.go
  • x/slashing/testutil/app_config.go
  • x/staking/testutil/app_config.go
Files skipped from review due to trivial changes (38)
  • .github/dependabot.yml
  • baseapp/block_gas_test.go
  • baseapp/utils_test.go
  • proto/cosmos/mint/module/v1/module.proto
  • proto/cosmos/mint/v1beta1/genesis.proto
  • proto/cosmos/mint/v1beta1/query.proto
  • proto/cosmos/mint/v1beta1/tx.proto
  • simapp/app_v2.go
  • simapp/test_helpers.go
  • tests/e2e/mint/suite.go
  • tests/integration/bank/keeper/deterministic_test.go
  • tests/integration/evidence/keeper/infraction_test.go
  • tests/integration/gov/module_test.go
  • tests/integration/rapidgen/rapidgen.go
  • tests/integration/slashing/keeper/keeper_test.go
  • tests/integration/staking/keeper/common_test.go
  • tests/integration/staking/keeper/deterministic_test.go
  • tests/integration/staking/simulation/operations_test.go
  • tests/integration/tx/aminojson/aminojson_test.go
  • tests/integration/tx/decode_test.go
  • testutil/configurator/configurator.go
  • testutil/integration/example_test.go
  • testutil/sims/address_helpers.go
  • testutil/testnet/genesis.go
  • x/consensus/testutil/helpers.go
  • x/distribution/client/cli/tx_test.go
  • x/feegrant/simulation/operations_test.go
  • x/group/keeper/keeper_test.go
  • x/group/keeper/msg_server_test.go
  • x/mint/CHANGELOG.md
  • x/mint/keeper/genesis_test.go
  • x/mint/keeper/grpc_query.go
  • x/mint/keeper/grpc_query_test.go
  • x/mint/keeper/keeper_test.go
  • x/mint/keeper/msg_server.go
  • x/mint/module.go
  • x/mint/module_test.go
  • x/mint/simulation/genesis_test.go
Additional comments (Suppressed): 27
go.work.example (1)
  • 24-24: The addition of ./x/mint to the project's workspace configuration is consistent with the PR's goal of making the mint package an independent Go module. Ensure that the mint module is properly set up and all dependencies are correctly managed within its own go.mod file.
x/mint/keeper/genesis.go (1)
  • 3-7: The import path for the mint/types package has been updated from github.com/cosmos/cosmos-sdk/x/mint/types to cosmossdk.io/x/mint/types. Ensure that the new location cosmossdk.io/x/mint/types is accessible and contains the required types for this module.
contrib/images/simd-env/Dockerfile (1)
  • 17-17: The addition of the mint module's go.mod and go.sum files to the Docker build context is consistent with the changes described in the PR summary. This change ensures that the mint module's dependencies are downloaded and available during the Docker build process. However, please verify that the mint module's dependencies do not conflict with the dependencies of other modules in the project.
x/mint/abci.go (1)
  • 9-10: The import paths for the mint module's keeper and types packages have been updated to reflect the new location of the module. Ensure that the new module at cosmossdk.io/x/mint is correctly set up and accessible.
tests/e2e/mint/grpc.go (1)
  • 8-9: The import path for minttypes has been updated from github.com/cosmos/cosmos-sdk/x/mint/types to cosmossdk.io/x/mint/types. Ensure that the new location cosmossdk.io/x/mint/types is accessible and contains the expected package.
proto/cosmos/mint/v1beta1/mint.proto (1)
  • 4-4: The go_package option has been updated to reflect the new location of the mint module. Ensure that the new location cosmossdk.io/x/mint/types is correctly set up and accessible.
simapp/simd/cmd/testnet_test.go (2)
  • 9-15: The import path for the mint module has been updated from github.com/cosmos/cosmos-sdk/x/mint to cosmossdk.io/x/mint. Ensure that the new location of the mint module is accessible and the module is correctly set up there.

  • 24-28: The import statement for the mint module has been removed. This is consistent with the change in the previous hunk where the import path for the mint module was updated. Ensure that this does not affect the functionality of the code.

x/mint/keeper/msg_server_test.go (1)
  • 4-7: The import paths have been updated to reflect the new location of the mint module. Ensure that the new location cosmossdk.io/x/mint/types is accessible and the module is correctly set up there.
x/mint/keeper/keeper.go (1)
  • 14-14: The import path for the mint types has been updated from github.com/cosmos/cosmos-sdk/x/mint/types to cosmossdk.io/x/mint/types. This change is consistent with the PR summary and indicates that the mint module has been moved to a new location. Ensure that the new location cosmossdk.io/x/mint/types is accessible and contains the necessary types for the mint module.
x/authz/testutil/app_config.go (2)
  • 4-4: The import path for the mint module has been updated from github.com/cosmos/cosmos-sdk/x/mint to cosmossdk.io/x/mint. Ensure that the new location is accessible and the module at the new location is compatible with the current application.

  • 14-14: The import for the mint module is missing in this hunk. If the mint module is still required in this file, it should be imported. If it's not needed anymore, ensure that removing it doesn't break any functionality.

x/distribution/testutil/app_config.go (2)
  • 1-7: The import path for the mint module has been updated from github.com/cosmos/cosmos-sdk/x/mint to cosmossdk.io/x/mint. Ensure that the new path is correct and the module is accessible at this location. Also, verify that all dependencies of the mint module are correctly handled in the new location.

  • 10-14: The import statement for the mint module has been removed. If the mint module is still required in this file, it should be imported from the new location cosmossdk.io/x/mint.

x/group/testutil/app_config.go (2)
  • 4-4: The import path for the mint module has been updated from github.com/cosmos/cosmos-sdk/x/mint to cosmossdk.io/x/mint. Ensure that the new location is accessible and the module at the new path is equivalent to the one at the old path. This change could potentially break the application if not handled properly.

  • 11-14: The import for the mint module is missing in this hunk. If the mint module is still being used in this file, it should be imported. If it's not being used, ensure that its removal doesn't affect the functionality of the application.

+    _ "cosmossdk.io/x/mint" // import as blank for app wiring
     _ "github.com/cosmos/cosmos-sdk/x/consensus"      // import as blank for app wiring
     _ "github.com/cosmos/cosmos-sdk/x/genutil"        // import as blank for app wiring
     _ "github.com/cosmos/cosmos-sdk/x/group/module"   // import as blank for app wiring
     _ "github.com/cosmos/cosmos-sdk/x/staking"        // import as blank for app wiring
simapp/app.go (2)
  • 42-44: The import paths for the mint module have been updated to reflect its new location. Ensure that the new module at cosmossdk.io/x/mint is correctly set up and accessible. Also, verify that all dependencies on the mint module in the codebase have been updated to use the new import paths.

  • 98-103: The import paths for the mint module have been removed from this section, which is consistent with the module's migration to a new location. No action is required here as long as the new import paths have been correctly updated elsewhere in the codebase.

simapp/app_config.go (2)
  • 35-42: The import paths for the mint module have been updated from github.com/cosmos/cosmos-sdk/x/mint to cosmossdk.io/x/mint. Ensure that the new location is accessible and the module at the new location is compatible with the rest of the codebase.

  • 67-73: The import statement for the mint module has been removed from this section. This change is consistent with the update in the import paths for the mint module in lines 35-42.

tests/integration/gov/keeper/keeper_test.go (2)
  • 8-11: The import path for minttypes has been updated from github.com/cosmos/cosmos-sdk/x/mint/types to cosmossdk.io/x/mint/types. Ensure that the new location cosmossdk.io/x/mint/types is accessible and contains the expected package.

  • 30-35: The import statement for minttypes from github.com/cosmos/cosmos-sdk/x/mint/types has been removed. If minttypes is used in this file, this will cause a compilation error. Please verify if this import is no longer necessary.

x/mint/simulation/genesis.go (1)
  • 8-14: The import path for the mint/types package has been updated from github.com/cosmos/cosmos-sdk/x/mint/types to cosmossdk.io/x/mint/types. This change is consistent with the PR summary, which mentions a migration of the mint module to a new location. Ensure that the new location cosmossdk.io/x/mint/types is accessible and contains the expected package.
simapp/app_test.go (2)
  • 18-24: The import path for the mint module has been updated from github.com/cosmos/cosmos-sdk/x/mint to cosmossdk.io/x/mint. Ensure that the new location is accessible and the module at the new path is functionally equivalent to the old one.

  • 39-44: The import statement for the mint module from github.com/cosmos/cosmos-sdk/x/mint has been removed. This is consistent with the change in the import path of the mint module to cosmossdk.io/x/mint.

x/mint/simulation/proposals.go (1)
  • 8-11: The import path for the mint module has been updated from github.com/cosmos/cosmos-sdk/x/mint/types to cosmossdk.io/x/mint/types. Ensure that the new location is accessible and contains the required types for the mint module.
api/cosmos/mint/module/v1/module.pulsar.go (1)
  • 563-587: The new hunk shows the addition of a new field auth to the Module message. This is a breaking change and will require all usages of the Module message to be updated to include the new auth field. Ensure that this change is properly communicated and handled in all parts of the codebase that use the Module message. Also, make sure that the new auth field is properly validated wherever the Module message is used.
- 	0x72, 0x6f, 0x74, 0x6f, 0x12, 0x15, 0x63, 0x6f, 0x73, 0x6d, 0x6f, 0x73, 0x2e, 0x6d, 0x69, 0x6e,
- 	0x74, 0x2e, 0x6d, 0x6f, 0x64, 0x75, 0x6c, 0x65, 0x2e, 0x76, 0x31, 0x1a, 0x20, 0x63, 0x6f, 0x73,
- 	0x6d, 0x6f, 0x73, 0x2f, 0x61, 0x70, 0x70, 0x2f, 0x76, 0x31, 0x61, 0x6c, 0x70, 0x68, 0x61, 0x31,
-	0x2f, 0x6d, 0x6f, 0x64, 0x75, 0x6c, 0x65, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x22, 0x81, 0x01,
-	0x0a, 0x06, 0x4d, 0x6f, 0x64, 0x75, 0x6c, 0x65, 0x12, 0x2c, 0x0a, 0x12, 0x66, 0x65, 0x65, 0x5f,
-	0x63, 0x6f, 0x6c, 0x6c, 0x65, 0x63, 0x74, 0x6f, 0x72, 0x5f, 0x6e, 0x61, 0x6d, 0x65, 0x18, 0x01,
-	0x20, 0x01, 0x28, 0x09, 0x52, 0x10, 0x66, 0x65, 0x65, 0x43, 0x6f, 0x6c, 0x6c, 0x65, 0x63, 0x74,
-	0x6f, 0x72, 0x4e, 0x61, 0x6d, 0x65, 0x12, 0x1c, 0x0a, 0x09, 0x61, 0x75, 0x74, 0x68, 0x6f, 0x72,
-	0x69, 0x74, 0x79, 0x18, 0x02, 0x20, 0x01, 0x28, 0x09, 0x52, 0x09, 0x61, 0x75, 0x74, 0x68, 0x6f,
-	0x72, 0x69, 0x74, 0x79, 0x3a, 0x2b, 0xba, 0xc0, 0x96, 0xda, 0x01, 0x25, 0x0a, 0x23, 0x67, 0x69,
-	0x74, 0x68, 0x75, 0x62, 0x2e, 0x63, 0x6f, 0x6d, 0x2f, 0x63, 0x6f, 0x73, 0x6d, 0x6f, 0x73, 0x2f,
-	0x63, 0x6f, 0x73, 0x6d, 0x6f, 0x73,


</blockquote></details></blockquote></details>



</details>

@@ -174,6 +173,7 @@ replace cosmossdk.io/x/protocolpool => ./x/protocolpool

// Below are the long-lived replace of the Cosmos SDK
replace (
cosmossdk.io/x/mint => ./x/mint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, short lived :D

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Commits Files that changed from the base of the PR and between 7c101eb and fc441dc.
Files ignored due to filter (7)
  • client/v2/go.mod
  • x/circuit/go.mod
  • x/feegrant/go.mod
  • x/mint/go.mod
  • x/mint/go.sum
  • x/nft/go.mod
  • x/upgrade/go.mod
Files selected for processing (1)
  • x/distribution/testutil/app_config.go (2 hunks)
Additional comments (Suppressed): 1
x/distribution/testutil/app_config.go (1)
  • 1-8: The import path for the mint module has been updated from github.com/cosmos/cosmos-sdk/x/mint to cosmossdk.io/x/mint. Ensure that the new import path is correct and the mint module is accessible at this location.

Comment on lines 11 to 15
_ "github.com/cosmos/cosmos-sdk/x/consensus" // import as blank for app wiring
_ "github.com/cosmos/cosmos-sdk/x/distribution" // import as blank for app wiring
_ "github.com/cosmos/cosmos-sdk/x/genutil" // import as blank for app wiring
_ "github.com/cosmos/cosmos-sdk/x/mint" // import as blank for app wiring
_ "github.com/cosmos/cosmos-sdk/x/staking" // import as blank for app wiring
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement for the mint module is missing in this hunk. If the mint module is still being used in this file, it should be imported.

15:
 )
+ import _ "cosmossdk.io/x/mint" // import as blank for app wiring
16:

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between fc441dc and d26daa2.
Files selected for processing (1)
  • x/distribution/testutil/app_config.go (2 hunks)
Additional comments (Suppressed): 2
x/distribution/testutil/app_config.go (2)
  • 1-7: The import path for the mint module has been updated from "github.com/cosmos/cosmos-sdk/x/mint" to "cosmossdk.io/x/mint". This change is consistent with the PR summary and should not cause any issues as long as the new module at "cosmossdk.io/x/mint" is equivalent to the old one at "github.com/cosmos/cosmos-sdk/x/mint". Please verify that the new module at "cosmossdk.io/x/mint" is fully functional and compatible with the rest of the codebase.

  • 11-15: The import statement for the mint module has been removed. This is consistent with the PR summary, which mentions that the mint module has been migrated to a new location. As long as the new module at "cosmossdk.io/x/mint" (imported in lines 1-7) is equivalent to the old one at "github.com/cosmos/cosmos-sdk/x/mint", this change should not cause any issues. Please verify that the new module at "cosmossdk.io/x/mint" is fully functional and compatible with the rest of the codebase.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between d26daa2 and 95b78e5.
Files selected for processing (1)
  • .github/workflows/test.yml (1 hunks)
Additional comments (Suppressed): 1
.github/workflows/test.yml (1)
  • 945-977: The new job test-x-mint is added to the GitHub Actions workflow. It checks out the code, sets up Go, checks for changes in the x/mint directory, runs tests, and performs SonarCloud analysis if there are changes and the pull request is not a draft. The Go version is set to "1.21", and the cache is enabled for the x/mint/go.sum file. The job runs on the latest version of Ubuntu. The projectBaseDir for the SonarCloud analysis is set to x/mint/. Ensure that the Go version and the projectBaseDir are correct and that the secrets GITHUB_TOKEN and SONAR_TOKEN are set in the repository settings.

x/mint/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 95b78e5 and f99e197.
Files selected for processing (1)
  • x/mint/sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (1)
  • x/mint/sonar-project.properties

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between f99e197 and b25e59d.
Files ignored due to filter (6)
  • go.mod
  • go.sum
  • simapp/go.mod
  • tests/go.mod
  • tests/starship/tests/go.mod
  • x/group/go.mod
Files selected for processing (12)
  • .github/workflows/test.yml (1 hunks)
  • go.work.example (1 hunks)
  • simapp/app.go (2 hunks)
  • simapp/app_config.go (2 hunks)
  • simapp/app_test.go (2 hunks)
  • simapp/app_v2.go (2 hunks)
  • tests/integration/rapidgen/rapidgen.go (2 hunks)
  • tests/integration/tx/aminojson/aminojson_test.go (2 hunks)
  • tests/integration/tx/decode_test.go (2 hunks)
  • x/group/keeper/keeper_test.go (2 hunks)
  • x/group/keeper/msg_server_test.go (1 hunks)
  • x/group/testutil/app_config.go (2 hunks)
Files skipped from review due to trivial changes (8)
  • go.work.example
  • simapp/app.go
  • simapp/app_v2.go
  • tests/integration/rapidgen/rapidgen.go
  • tests/integration/tx/aminojson/aminojson_test.go
  • tests/integration/tx/decode_test.go
  • x/group/keeper/keeper_test.go
  • x/group/keeper/msg_server_test.go
Additional comments (Suppressed): 7
x/group/testutil/app_config.go (2)
  • 4-5: The import path for the mint module has been updated from "github.com/cosmos/cosmos-sdk/x/mint" to "cosmossdk.io/x/mint". Ensure that the new path is correct and accessible. Also, verify that all references to the mint module in the codebase have been updated to the new path.

  • 14-14: The import statement for the mint module has been removed from this location. This change is consistent with the update in lines 4-5 where the mint module is now imported with the new path.

simapp/app_config.go (2)
  • 37-44: The import path for the mint module has been updated from "github.com/cosmos/cosmos-sdk/x/mint" to "cosmossdk.io/x/mint". Ensure that the new path is correct and accessible. Also, verify that all references to the mint module in the codebase have been updated to the new path.

  • 67-72: The import statement for the mint module has been removed from this section. This change is consistent with the update in the previous hunk where the mint module is now imported from a new path. No action is required here as long as the new import path for the mint module is correct.

simapp/app_test.go (2)
  • 22-22: The import path for the mint package has been updated from "github.com/cosmos/cosmos-sdk/x/mint" to "cosmossdk.io/x/mint". Ensure that the new path is correct and the package is accessible at this location. Also, verify that all references to the mint package in the codebase have been updated to the new path.

  • 39-44: The import statement for the mint package has been removed. If the mint package is still being used in this file, this will cause a compilation error. Please ensure that all necessary imports are included.

.github/workflows/test.yml (1)
  • 945-978: The new job test-x-mint is added to the workflow to run tests and perform code coverage analysis for the x/mint package. It checks out the code, sets up Go, caches dependencies, and determines if there are changes in the x/mint package. If there are changes, it runs tests and performs SonarCloud analysis if the pull request is not a draft. The Go version used is 1.21. The job uses the get-diff-action to determine if there are changes in the x/mint package. The job is well-structured and follows the pattern of the other jobs in the workflow.

However, the sonarcloud-github-action is used from the master branch. It's a good practice to use a specific version of a GitHub action to avoid unexpected changes when the action is updated.

-        uses: SonarSource/sonarcloud-github-action@master
+        uses: SonarSource/sonarcloud-github-action@v1.6

@tac0turtle
Copy link
Member

going to close then reopen this as the conflicts take longer to solve than opening a new pr

@tac0turtle tac0turtle closed this Oct 27, 2023
@julienrbrt julienrbrt deleted the go.mod-add-x-mint branch October 27, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract x/mint to its own go.mod
4 participants