Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump google.golang.org/grpc from 1.58.2 to 1.58.3 in /x/accounts #18057

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 11, 2023

Bumps google.golang.org/grpc from 1.58.2 to 1.58.3.

Release notes

Sourced from google.golang.org/grpc's releases.

Release v1.58.3

Security

  • server: prohibit more than MaxConcurrentStreams handlers from running at once (CVE-2023-44487)

    In addition to this change, applications should ensure they do not leave running tasks behind related to the RPC before returning from method handlers, or should enforce appropriate limits on any such work.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.2 to 1.58.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.58.2...v1.58.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner October 11, 2023 02:02
@dependabot dependabot bot added A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file labels Oct 11, 2023
@julienrbrt julienrbrt closed this Oct 11, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 11, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/x/accounts/google.golang.org/grpc-1.58.3 branch October 11, 2023 05:43
@odeke-em
Copy link
Collaborator

odeke-em commented Dec 3, 2023

@julienrbrt why did we close this PR? This PR would have fixed a vulnerability https://deps.dev/go/google.golang.org%2Fgrpc/v1.58.0 as grpc v1.58.2 is vulnerable to https://deps.dev/advisory/osv/GO-2023-2153 and a whole lot of vulnerabiliities list out in

@julienrbrt
Copy link
Member

@julienrbrt why did we close this PR? This PR would have fixed a vulnerability https://deps.dev/go/google.golang.org%2Fgrpc/v1.58.0 as grpc v1.58.2 is vulnerable to https://deps.dev/advisory/osv/GO-2023-2153 and a whole lot of vulnerabiliities list out in

It was a duplicate: #18096.
Dependabot checks all go.mod and opens a PR for all of them. However, we have an action to bump everything in one dependabot PR: https://github.com/cosmos/cosmos-sdk/blob/main/.github/workflows/dependabot-update-all.yml
I am then closing all duplicates.

@odeke-em
Copy link
Collaborator

odeke-em commented Dec 3, 2023

Gotcha and thank you @julienrbrt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants