Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(network): call app.Close() on network cleanup (backport #18249) #18251

Merged
merged 4 commits into from
Oct 25, 2023
Merged

refactor(network): call app.Close() on network cleanup (backport #18249) #18251

merged 4 commits into from
Oct 25, 2023

Commits on Oct 25, 2023

  1. refactor(network): call app.Close() on network cleanup (#18249) 

    (cherry picked from commit 139a29e)

# Conflicts:
#	testutil/network/network.go
#	testutil/network/util.go
    @julienrbrt @mergify
    julienrbrt authored and mergify[bot] committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    00551e9 View commit details
    Browse the repository at this point in the history

  2. fix conflicts

    @julienrbrt
    julienrbrt committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    db0c983 View commit details
    Browse the repository at this point in the history

  3. move up defer and call close even if tm not running

    @julienrbrt
    julienrbrt committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    5f1fe25 View commit details
    Browse the repository at this point in the history

  4. changelog

    @julienrbrt
    julienrbrt committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    e81c669 View commit details
    Browse the repository at this point in the history