Basecoin fix #1919
Closed
Basecoin fix #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gblue1223
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1919 +/- ##
=======================================
Coverage 60.63% 60.63%
=======================================
Files 119 119
Lines 6917 6917
=======================================
Hits 4194 4194
Misses 2484 2484
Partials 239 239 |
ValarDragon
requested changes
Aug 4, 2018
examples/basecoin/app/app.go
Outdated
| @@ -102,6 +104,7 @@ func MakeCodec() *wire.Codec { | |||
| // register custom types | |||
| cdc.RegisterInterface((*auth.Account)(nil), nil) | |||
| cdc.RegisterConcrete(&types.AppAccount{}, "basecoin/Account", nil) | |||
| cdc.RegisterConcrete(auth.StdTx{}, "auth/StdTx", nil) | |||
There was a problem hiding this comment.
Can you do:
auth.RegisterWire(cdc *wire.Codec)Other than that, looks good to me!
There was a problem hiding this comment.
I've updated the resister code as you mentioned. :)
Closed
4 tasks
ValarDragon
approved these changes
Aug 6, 2018
|
Thanks for the PR @gblue1223! We will get it reviewed soon. |
cwgoes
approved these changes
Aug 8, 2018
|
Ah, unfortunately you based this on |
2 tasks
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.cmd/gaiaandexamples/For Admin Use: