-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(storev2): update snapshot manager and migration manager tests #20441
Merged
Merged
Changes from 18 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
53e4b18
add tests
sontrinh16 12a569e
Merge branch 'main' into son/add_store_v2_tests
sontrinh16 214605b
change initial version to 0
sontrinh16 aefee6a
Revert "change initial version to 0"
sontrinh16 495ab79
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk
sontrinh16 f761eb1
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk
sontrinh16 13cd0df
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk
sontrinh16 ea4edd5
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk
sontrinh16 be64070
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk
sontrinh16 b882b6b
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk
sontrinh16 9d9a5ab
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk
sontrinh16 88b5176
Merge branch 'main' into son/add_store_v2_tests
sontrinh16 dce2bc7
modify test
sontrinh16 411aac9
Merge branch 'main' into son/add_store_v2_tests
sontrinh16 820138f
add snapshot take and prune test
sontrinh16 32b8c4e
update snapshot_take_restore test
sontrinh16 3bda63a
Merge branch 'son/add_store_v2_tests' of https://github.com/cosmos/co…
sontrinh16 efa0806
Merge branch 'main' into son/add_store_v2_tests
sontrinh16 d9d5bd2
address comments
sontrinh16 909bc02
Merge branch 'son/add_store_v2_tests' of https://github.com/cosmos/co…
sontrinh16 51c8d84
Merge branch 'main' into son/add_store_v2_tests
sontrinh16 5ae1ca6
Merge branch 'main' into son/add_store_v2_tests
sontrinh16 56ecd5d
lint
sontrinh16 384ac63
fix test
sontrinh16 71b7180
Merge branch 'main' into son/add_store_v2_tests
sontrinh16 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to check if the restore is done? maybe add more confirmation after restoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this is the check for error when performing restore, i already added a confirmation after restoring above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I mean is, should we compare the restored data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah gotcha