fix(baseapp): return events from preblocker in FinalizeBlockResponse #21159
Conversation
WalkthroughWalkthroughThe changes enhance the event handling mechanism within the Changes
Sequence Diagram(s)sequenceDiagram
participant BaseApp
participant EventManager
participant PreBlocker
BaseApp->>PreBlocker: Call pre-blocker
PreBlocker-->>BaseApp: Emit "preblockertest" event
BaseApp->>EventManager: Append events from EventManager
EventManager-->>BaseApp: Return events
BaseApp->>BaseApp: Finalize block with events
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
This comment has been minimized.
This comment has been minimized.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if err := app.preBlock(req); err != nil { | ||
| return nil, err | ||
| } | ||
| events = append(events, app.finalizeBlockState.ctx.EventManager().ABCIEvents()...) | ||
|
|
||
| beginBlock, err := app.beginBlock(req) | ||
| if err != nil { |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/abci.go:725)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/abci.go:872)
tac0turtle
added
backport/v0.50.x
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- baseapp/abci.go (1 hunks)
- baseapp/abci_test.go (1 hunks)
Additional context used
Path-based instructions (2)
baseapp/abci.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.baseapp/abci_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (4)
baseapp/abci.go (1)
792-792: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that the inclusion of
EventManagerevents does not introduce any unintended side effects in the event handling mechanism.baseapp/abci_test.go (3)
2301-2303: Confirm Event Emission in PreBlocker FunctionThe event emission within the pre-blocker function is correctly implemented. This ensures that the event "preblockertest" with an attribute indicating the block height is emitted.
2306-2310: Confirm Test Assertions for Emitted EventThe test assertions correctly validate the presence of the emitted event and confirm its type as "preblockertest". This ensures the pre-blocker function's event emission is properly tested.
Line range hint
2312-2314:
Confirm Error Handling in PreBlocker FunctionThe error handling within the pre-blocker function is correctly implemented and tested. This ensures that the function handles errors as expected and the test verifies this behavior.
julienrbrt
changed the title
Description
The events emitted during preblocker were being discarded, now we prepend them to the events returned in FinalizeBlockResponse.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes