Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: migrate bank to hybridcodec #5681

Merged
merged 9 commits into from
Feb 20, 2020
Merged

proto: migrate bank to hybridcodec #5681

merged 9 commits into from
Feb 20, 2020

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Feb 20, 2020 •
edited by alexanderbez
Loading

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@tac0turtle
proto: migrate bank to hybridcodec
0221286 
- ref #5444

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle added T: State Machine Breaking State machine breaking changes (impacts consensus). C:Encoding labels Feb 20, 2020
@tac0turtle tac0turtle self-assigned this Feb 20, 2020
@alexanderbez alexanderbez mentioned this pull request Feb 20, 2020
Closed
28 tasks
@tac0turtle tac0turtle marked this pull request as ready for review February 20, 2020 11:49
alexanderbez
alexanderbez approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit ebbfaf2 into master Feb 20, 2020
@alexanderbez alexanderbez deleted the proto/bank branch February 20, 2020 14:24
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@tac0turtle
Merge PR cosmos#5681: proto: migrate bank to hybridcodec
5b22964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees

@tac0turtle tac0turtle

Labels
C:Encoding C:x/bank T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tac0turtle @alexanderbez