Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DefaultHistoricalEntries to 100 #6059

Merged
merged 6 commits into from
Apr 23, 2020
Merged

Update DefaultHistoricalEntries to 100 #6059

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f83deef
Update DefaultHistoricalEntries to 1000
jackzampolin Apr 22, 2020
cea9131
hist entries sims and comment on simapp
fedekunze Apr 22, 2020
e96797d
changelog and godoc
fedekunze Apr 22, 2020
8a405d6
update sim param change
fedekunze Apr 22, 2020
99270b2
update default to 100
fedekunze Apr 23, 2020
a827cb4
Merge branch 'master' into jack/hist-entries
mergify[bot] Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x/staking/types/params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const (

// DefaultHistorical entries is 0 since it must only be non-zero for
fedekunze marked this conversation as resolved.
Show resolved Hide resolved
// IBC connected chains
DefaultHistoricalEntries uint32 = 0
DefaultHistoricalEntries uint32 = 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any rationale behind this value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @AdityaSripal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will govern how low-latency IBC handshakes must be in order to complete in time. I think 1000 is fine, it's probably even fine to use something much lower, like 100.

Copy link
Contributor

@alexanderbez alexanderbez Apr 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Are historical entries persisted in state? If so, we should opt for a lower bound instead (nitpick).

Copy link
Collaborator

@fedekunze fedekunze Apr 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after block 100 the new ones start overriding the old ones so there are always at most 100

)

// nolint - Keys for parameter access
Expand Down