Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some Param types from Keeper to Types in staking #6451

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Jun 16, 2020

Description

I realized while trying to make gaia work that for some reason those types were in keeper package instead of types, it was the only one, so I moved it to be consistent.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@jgimeno jgimeno added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jun 16, 2020
@jgimeno jgimeno added the R4R label Jun 16, 2020
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #6451 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #6451      +/-   ##
==========================================
- Coverage   55.74%   55.74%   -0.01%     
==========================================
  Files         466      466              
  Lines       27890    27890              
==========================================
- Hits        15548    15546       -2     
- Misses      11229    11231       +2     
  Partials     1113     1113              

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 16, 2020
@alessio alessio merged commit c134e89 into master Jun 16, 2020
@alessio alessio deleted the jonathan/staking-consistency branch June 16, 2020 17:59
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants