Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CLI cleanup #6651

Merged
merged 3 commits into from
Jul 8, 2020
Merged

More CLI cleanup #6651

merged 3 commits into from
Jul 8, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 8, 2020

Description

  • Improve gentx UX.
  • Remove default directory args.
  • Allow moniker to be provided.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added C:CLI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #6651 into master will increase coverage by 1.12%.
The diff coverage is 9.52%.

@@            Coverage Diff             @@
##           master    #6651      +/-   ##
==========================================
+ Coverage   56.45%   57.58%   +1.12%     
==========================================
  Files         412      500      +88     
  Lines       24503    29999    +5496     
==========================================
+ Hits        13834    17275    +3441     
- Misses       9578    11479    +1901     
- Partials     1091     1245     +154     

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Pending changelog entry for genutil changes

@alexanderbez alexanderbez merged commit b25e3fc into master Jul 8, 2020
@alexanderbez alexanderbez deleted the bez/cli-cleanup branch July 8, 2020 17:57
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants