Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: Add Wrap handy method #8845

Merged
merged 3 commits into from
Mar 16, 2021
Merged

errors: Add Wrap handy method #8845

merged 3 commits into from
Mar 16, 2021

Conversation

robert-zaremba
Copy link
Collaborator

No description provided.

@robert-zaremba
Copy link
Collaborator Author

Guys, what do you think about this?

@alessio
Copy link
Contributor

alessio commented Mar 10, 2021

It does not do any harm 👍

Copy link
Contributor

@cyberbono3 cyberbono3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it just extends basic error with more details.

@alessio alessio added A:automerge Automatically merge PR once all prerequisites pass. backport/0.42.x (Stargate) labels Mar 14, 2021
@orijbot
Copy link

orijbot commented Mar 15, 2021

@orijbot
Copy link

orijbot commented Mar 15, 2021

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #8845 (282a0f0) into master (42919c8) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8845      +/-   ##
==========================================
- Coverage   59.17%   59.16%   -0.01%     
==========================================
  Files         571      571              
  Lines       31800    31802       +2     
==========================================
  Hits        18817    18817              
- Misses      10780    10782       +2     
  Partials     2203     2203              
Impacted Files Coverage Δ
types/errors/errors.go 79.31% <0.00%> (-2.84%) ⬇️
x/auth/tx/service.go 72.85% <100.00%> (ø)

@robert-zaremba robert-zaremba marked this pull request as ready for review March 15, 2021 19:38
@robert-zaremba
Copy link
Collaborator Author

Github CI has problems today - I think I'm rerunning this tests already 4 times.

@mergify mergify bot merged commit 4bd695d into master Mar 16, 2021
@mergify mergify bot deleted the robert/errors-wrap branch March 16, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants