revert: Turn staking power reduction into an on-chain param #9495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Simulations
C:x/authz
C:x/bank
C:x/distribution
4 tasks
|
Would love to have @sunnya97 @alexanderbez and/or @anilcse ACK before merging this |
alexanderbez
approved these changes
Jun 10, 2021
amaury1093
force-pushed
the
am/9447-revert-powerred
branch
from
a05b55c
to
745154a
Compare
github-actions
bot
removed
C:x/feegrant
C:Simulations
C:x/bank
C:x/staking
C:CLI
C:x/distribution
github-actions
bot
added
C:CLI
C:Simulations
C:x/staking
T:Docs
…447-revert-powerred
Yeah, good idea, I changed. The diff is way smaller now, R4R again. |
Codecov Report
@@ Coverage Diff @@
## master #9495 +/- ##
==========================================
+ Coverage 60.54% 60.59% +0.05%
==========================================
Files 590 589 -1
Lines 37296 37211 -85
==========================================
- Hits 22579 22547 -32
+ Misses 12768 12721 -47
+ Partials 1949 1943 -6
|
robert-zaremba
approved these changes
Jun 14, 2021
| @@ -112,7 +112,7 @@ func (k Keeper) BlockValidatorUpdates(ctx sdk.Context) []abci.ValidatorUpdate { | |||
| func (k Keeper) ApplyAndReturnValidatorSetUpdates(ctx sdk.Context) (updates []abci.ValidatorUpdate, err error) { | |||
| params := k.GetParams(ctx) | |||
| maxValidators := params.MaxValidators | |||
| powerReduction := params.PowerReduction | |||
| powerReduction := k.PowerReduction(ctx) | |||
amaury1093
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #9447
This PR partially reverts #8505. Namely:
powerReductionfunction argument to staking functions. This allows us to rely less on global variables in said functions.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change